linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com,
	Quanyang Wang <quanyang.wang@windriver.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: zynqmp: Remove not documented is-dual property
Date: Mon, 9 Aug 2021 04:52:13 +0300	[thread overview]
Message-ID: <YRCKTfxmo60uPzp5@pendragon.ideasonboard.com> (raw)
In-Reply-To: <876c53b92f99623bae45d5c0c5ae79ee3e24f745.1628239345.git.michal.simek@xilinx.com>

Hi Michal,

Thank you for the patch.

On Fri, Aug 06, 2021 at 10:42:29AM +0200, Michal Simek wrote:
> Remove is-dual not documented property and also update comment about QSPI
> sizes to reflect dual configuration as 16MB + 16MB.
> Only single configuration is supported now.
> 
> Reported-by: Quanyang Wang <quanyang.wang@windriver.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 3 +--
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts | 3 +--
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts | 3 +--
>  3 files changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> index becfc23a5610..3d8d14ef1ede 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> @@ -937,9 +937,8 @@ &psgtr {
>  
>  &qspi {
>  	status = "okay";
> -	is-dual = <1>;
>  	flash@0 {
> -		compatible = "m25p80", "jedec,spi-nor"; /* 32MB */
> +		compatible = "m25p80", "jedec,spi-nor"; /* 16MB + 16MB */
>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  		reg = <0x0>;
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> index d2219373580a..057c04352591 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> @@ -931,9 +931,8 @@ &psgtr {
>  
>  &qspi {
>  	status = "okay";
> -	is-dual = <1>;
>  	flash@0 {
> -		compatible = "m25p80", "jedec,spi-nor"; /* 32MB */
> +		compatible = "m25p80", "jedec,spi-nor"; /* 16MB + 16MB */
>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  		reg = <0x0>;
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> index dac5ba67a160..e1fff62a4cd5 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dts
> @@ -773,9 +773,8 @@ &psgtr {
>  
>  &qspi {
>  	status = "okay";
> -	is-dual = <1>;
>  	flash@0 {
> -		compatible = "m25p80", "jedec,spi-nor"; /* 32MB */
> +		compatible = "m25p80", "jedec,spi-nor"; /* 16MB + 16MB */
>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  		reg = <0x0>;

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2021-08-09  1:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06  8:42 [PATCH] arm64: zynqmp: Remove not documented is-dual property Michal Simek
2021-08-09  1:52 ` Laurent Pinchart [this message]
2021-08-25  6:21 ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRCKTfxmo60uPzp5@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=git@xilinx.com \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=monstr@monstr.eu \
    --cc=quanyang.wang@windriver.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).