From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Will Deacon <will@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
John Garry <john.garry@huawei.com>,
Andi Kleen <ak@linux.intel.com>,
Riccardo Mancini <rickyman7@gmail.com>,
Jin Yao <yao.jin@linux.intel.com>,
Li Huafei <lihuafei1@huawei.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH v1 1/3] perf env: Track kernel 64-bit mode in environment
Date: Mon, 9 Aug 2021 17:11:44 -0300 [thread overview]
Message-ID: <YRGMAHj3MUndBEUq@kernel.org> (raw)
In-Reply-To: <20210809112727.596876-2-leo.yan@linaro.org>
Em Mon, Aug 09, 2021 at 07:27:25PM +0800, Leo Yan escreveu:
> It's useful to know that the kernel is running in 32-bit or 64-bit
> mode. E.g. We can decide if perf tool is running in compat mode
> based on the info.
>
> This patch adds an item "kernel_is_64_bit" into session's environment
> structure perf_env, its value is initialized based on the architecture
> string.
Thanks, applied.
- Arnaldo
> Suggested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> tools/perf/util/env.c | 24 +++++++++++++++++++++++-
> tools/perf/util/env.h | 3 +++
> 2 files changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/env.c b/tools/perf/util/env.c
> index ab341050be46..8f7ff0035c41 100644
> --- a/tools/perf/util/env.c
> +++ b/tools/perf/util/env.c
> @@ -219,13 +219,35 @@ void perf_env__exit(struct perf_env *env)
> zfree(&env->hybrid_cpc_nodes);
> }
>
> -void perf_env__init(struct perf_env *env __maybe_unused)
> +void perf_env__init(struct perf_env *env)
> {
> #ifdef HAVE_LIBBPF_SUPPORT
> env->bpf_progs.infos = RB_ROOT;
> env->bpf_progs.btfs = RB_ROOT;
> init_rwsem(&env->bpf_progs.lock);
> #endif
> + env->kernel_is_64_bit = -1;
> +}
> +
> +static void perf_env__init_kernel_mode(struct perf_env *env)
> +{
> + const char *arch = perf_env__raw_arch(env);
> +
> + if (!strncmp(arch, "x86_64", 6) || !strncmp(arch, "aarch64", 7) ||
> + !strncmp(arch, "arm64", 5) || !strncmp(arch, "mips64", 6) ||
> + !strncmp(arch, "parisc64", 8) || !strncmp(arch, "riscv64", 7) ||
> + !strncmp(arch, "s390x", 5) || !strncmp(arch, "sparc64", 7))
> + env->kernel_is_64_bit = 1;
> + else
> + env->kernel_is_64_bit = 0;
> +}
> +
> +int perf_env__kernel_is_64_bit(struct perf_env *env)
> +{
> + if (env->kernel_is_64_bit == -1)
> + perf_env__init_kernel_mode(env);
> +
> + return env->kernel_is_64_bit;
> }
>
> int perf_env__set_cmdline(struct perf_env *env, int argc, const char *argv[])
> diff --git a/tools/perf/util/env.h b/tools/perf/util/env.h
> index 6824a7423a2d..1f5175820a05 100644
> --- a/tools/perf/util/env.h
> +++ b/tools/perf/util/env.h
> @@ -61,6 +61,7 @@ struct perf_env {
> unsigned long long total_mem;
> unsigned int msr_pmu_type;
> unsigned int max_branches;
> + int kernel_is_64_bit;
>
> int nr_cmdline;
> int nr_sibling_cores;
> @@ -143,6 +144,8 @@ extern struct perf_env perf_env;
>
> void perf_env__exit(struct perf_env *env);
>
> +int perf_env__kernel_is_64_bit(struct perf_env *env);
> +
> int perf_env__set_cmdline(struct perf_env *env, int argc, const char *argv[]);
>
> int perf_env__read_cpuid(struct perf_env *env);
> --
> 2.25.1
>
--
- Arnaldo
next prev parent reply other threads:[~2021-08-09 20:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 11:27 [PATCH v1 0/3] perf: Support compat mode for AUX ring buffer Leo Yan
2021-08-09 11:27 ` [PATCH v1 1/3] perf env: Track kernel 64-bit mode in environment Leo Yan
2021-08-09 20:11 ` Arnaldo Carvalho de Melo [this message]
2021-08-09 11:27 ` [PATCH v1 2/3] perf auxtrace: Add compat_auxtrace_mmap__{read_head|write_tail} Leo Yan
2021-08-09 20:12 ` Arnaldo Carvalho de Melo
2021-08-12 9:23 ` Adrian Hunter
2021-08-13 16:22 ` James Clark
2021-08-23 9:51 ` Leo Yan
2021-08-23 10:57 ` James Clark
2021-08-23 12:13 ` Leo Yan
2021-08-23 16:00 ` James Clark
2021-08-24 2:13 ` Leo Yan
2021-08-09 11:27 ` [PATCH v1 3/3] perf auxtrace arm: Support compat_auxtrace_mmap__{read_head|write_tail} Leo Yan
2021-08-23 12:23 ` James Clark
2021-08-23 13:30 ` Leo Yan
2021-08-23 13:39 ` Russell King (Oracle)
2021-08-23 14:54 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRGMAHj3MUndBEUq@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=catalin.marinas@arm.com \
--cc=coresight@lists.linaro.org \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=lihuafei1@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rickyman7@gmail.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).