linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Alistair Francis <alistair@alistair23.me>
Cc: robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
	linux-imx@nxp.com, kernel@pengutronix.de,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	alistair23@gmail.com
Subject: Re: [PATCH v10 02/11] mfd: simple-mfd-i2c: Add a Kconfig name
Date: Tue, 10 Aug 2021 08:53:21 +0100	[thread overview]
Message-ID: <YRIwcXggWWj1+DDf@google.com> (raw)
In-Reply-To: <20210807103940.152-3-alistair@alistair23.me>

On Sat, 07 Aug 2021, Alistair Francis wrote:

You need a better commit message.

What are you doing?
Why are you doing it?
What happens if you don't do it?

> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
>  drivers/mfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I guess there's no harm in it.

That does mean you'll need a bespoke defconfig to run your build,
which is not advisable for generic maintenance and testing purposes.
What architecture does your H/W operate on?

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 6a3fd2d75f96..09a939f8b7ff 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1176,7 +1176,7 @@ config MFD_SI476X_CORE
>  	  module will be called si476x-core.
>  
>  config MFD_SIMPLE_MFD_I2C
> -	tristate
> +	tristate "Simple MFD device"

That's not right.  You're saying:

  "Simple Multi-Functional Device device"

It should be something more like:

  "Simple Multi-Functional Device support (I2C)"

>  	depends on I2C
>  	select REGMAP_I2C
>  	help

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2021-08-10  7:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-07 10:39 [PATCH v10 00/11] Add support for the silergy,sy7636a Alistair Francis
2021-08-07 10:39 ` [PATCH v10 01/11] dt-bindings: mfd: Initial commit of silergy,sy7636a.yaml Alistair Francis
2021-08-13 20:39   ` Rob Herring
2021-08-07 10:39 ` [PATCH v10 02/11] mfd: simple-mfd-i2c: Add a Kconfig name Alistair Francis
2021-08-10  7:53   ` Lee Jones [this message]
2021-08-15 11:55     ` Alistair Francis
2021-08-07 10:39 ` [PATCH v10 03/11] mfd: simple-mfd-i2c: Enable support for the silergy,sy7636a Alistair Francis
2021-08-07 10:39 ` [PATCH v10 04/11] regulator: sy7636a: Use the regmap directly Alistair Francis
2021-08-07 10:39 ` [PATCH v10 05/11] regulator: sy7636a: Remove requirement on sy7636a mfd Alistair Francis
2021-08-07 10:39 ` [PATCH v10 06/11] thermal: sy7636a: Add thermal driver for sy7636a Alistair Francis
2021-08-07 10:39 ` [PATCH v10 07/11] hwmon: sy7636a: Add temperature " Alistair Francis
2021-08-07 10:39 ` [PATCH v10 08/11] ARM: imx_v6_v7_defconfig: Enable silergy,sy7636a Alistair Francis
2021-08-07 10:39 ` [PATCH v10 09/11] ARM: dts: imx7d: remarkable2: " Alistair Francis
2021-08-07 10:39 ` [PATCH v10 10/11] ARM: imx_v6_v7_defconfig: Enable backlight class devices Alistair Francis
2021-08-07 10:39 ` [PATCH v10 11/11] ARM: dts: imx7d: remarkable2: Enable lcdif Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRIwcXggWWj1+DDf@google.com \
    --to=lee.jones@linaro.org \
    --cc=alistair23@gmail.com \
    --cc=alistair@alistair23.me \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).