From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: John Garry <john.garry@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, yao.jin@linux.intel.com,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
irogers@google.com, linuxarm@huawei.com
Subject: Re: [PATCH 02/11] perf jevents: Relocate test events to cpu folder
Date: Tue, 10 Aug 2021 11:01:07 -0300 [thread overview]
Message-ID: <YRKGo1AtfBn85sZ7@kernel.org> (raw)
In-Reply-To: <88294bb8-6fb1-b485-446c-4ec15ff28d4a@huawei.com>
Em Mon, Aug 09, 2021 at 04:46:04PM +0100, John Garry escreveu:
> On 03/08/2021 09:19, John Garry wrote:
> > So I think we need something like this:
> >
> > ----->8--------
> >
> > From a08df563665e9ec088b1af86ceed058497e112a4 Mon Sep 17 00:00:00 2001
> > From: John Garry <john.garry@huawei.com>
> > Date: Tue, 3 Aug 2021 08:44:09 +0100
> > Subject: [PATCH] perf jevents: Make build dependency on test JSONs
> >
> > Currently all JSONs and the mapfile for an arch are dependencies for
> > building pmu-events.c
> >
> > The test JSONs are missing as a dependency, so add them.
> >
> > Signed-off-by: John Garry <john.garry@huawei.com>
> >
> > diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build
> > index 215ba30b8534..a055dee6a46a 100644
> > --- a/tools/perf/pmu-events/Build
> > +++ b/tools/perf/pmu-events/Build
> > @@ -6,10 +6,13 @@ pmu-events-y += pmu-events.o
> > JDIR = pmu-events/arch/$(SRCARCH)
> > JSON = $(shell [ -d $(JDIR) ] && \
> > find $(JDIR) -name '*.json' -o -name 'mapfile.csv')
> > +JDIR_TEST = pmu-events/arch/test
> > +JSON_TEST = $(shell [ -d $(JDIR_TEST) ] && \
> > + find $(JDIR_TEST) -name '*.json')
> >
> > #
> > # Locate/process JSON files in pmu-events/arch/
> > # directory and create tables in pmu-events.c.
> > #
> > -$(OUTPUT)pmu-events/pmu-events.c: $(JSON) $(JEVENTS)
> > +$(OUTPUT)pmu-events/pmu-events.c: $(JSON) $(JSON_TEST) $(JEVENTS)
> > $(Q)$(call echo-cmd,gen)$(JEVENTS) $(SRCARCH) pmu-events/arch
> > $(OUTPUT)pmu-events/pmu-events.c $(V)
> >
> >
> > -----8<-----
>
> Hi Arnaldo,
>
> Shall I send this as a formal patch?
The question is when should I apply this patch? After this series? After
the patch I commented about, before?
- Arnaldo
next prev parent reply other threads:[~2021-08-10 14:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 13:56 [PATCH 00/11] perf test: Improve pmu-events support John Garry
2021-07-29 13:56 ` [PATCH 01/11] perf test: Factor out pmu-events event comparison John Garry
2021-07-29 13:56 ` [PATCH 02/11] perf jevents: Relocate test events to cpu folder John Garry
2021-08-02 14:54 ` Arnaldo Carvalho de Melo
2021-08-02 15:02 ` John Garry
2021-08-03 8:19 ` John Garry
2021-08-09 15:46 ` John Garry
2021-08-10 14:01 ` Arnaldo Carvalho de Melo [this message]
2021-08-10 14:23 ` John Garry
2021-08-10 14:34 ` Arnaldo Carvalho de Melo
2021-08-10 17:58 ` Arnaldo Carvalho de Melo
2021-08-11 7:59 ` John Garry
2021-08-11 18:38 ` Arnaldo Carvalho de Melo
2021-07-29 13:56 ` [PATCH 03/11] perf test: Declare pmu-events test events separately John Garry
2021-07-29 13:56 ` [PATCH 04/11] perf test: Factor out pmu-events alias comparison John Garry
2021-07-29 13:56 ` [PATCH 05/11] perf test: Test pmu-events core aliases separately John Garry
2021-07-29 13:56 ` [PATCH 06/11] perf pmu: Check .is_uncore field in pmu_add_cpu_aliases_map() John Garry
2021-07-29 13:56 ` [PATCH 07/11] perf test: Re-add pmu-event uncore PMU alias test John Garry
2021-07-29 13:56 ` [PATCH 08/11] perf test: Add more pmu-events uncore aliases John Garry
2021-07-29 13:56 ` [PATCH 09/11] perf pmu: Make pmu_add_sys_aliases() public John Garry
2021-07-29 13:56 ` [PATCH 10/11] perf jevents: Print SoC name per system event table John Garry
2021-07-29 13:56 ` [PATCH 11/11] perf test: Add pmu-events sys event support John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRKGo1AtfBn85sZ7@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).