From: Greg KH <gregkh@linuxfoundation.org>
To: Prasad Sodagudi <psodagud@codeaurora.org>
Cc: rjw@rjwysocki.net, len.brown@intel.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
pavel@ucw.cz
Subject: Re: [PATCH v2] PM: sleep: core: Avoid setting power.must_resume to false
Date: Tue, 10 Aug 2021 17:06:05 +0200 [thread overview]
Message-ID: <YRKV3aYPvQhkL/9m@kroah.com> (raw)
In-Reply-To: <1628602932-246733-1-git-send-email-psodagud@codeaurora.org>
On Tue, Aug 10, 2021 at 06:42:11AM -0700, Prasad Sodagudi wrote:
> This is regarding suspend/resume(s2idle) scenario of devices and difference
> between the LTS kernels 5.4 and 5.10 with respect to devices suspend and
> resume. Observing that devices suspended in suspend_late stage are not
> getting resumed in resume_early stage.
> 1) LTS kernel 5.4 kernel do not have this problem but 5.10 kernel
> shows this problem.
> 2) 'commit 6e176bf8d461 ("PM: sleep: core: Do not skip callbacks in the resume phase")'
> is skipping the driver early_resume callbacks.
>
> In device_resume_early function dev->power.must_resume is used to skip the
> resume call back. It looks this function is expecting that,
> __device_suspend_noirq() would set dev->power.must_resume = true for the
> devices which does not have DPM_FLAG_MAY_SKIP_RESUME flag set.
>
> 3) Problematic scenario is as follows - During the device suspend/resume
> scenario all the devices in the suspend_late stage are successful and some
> device can fail to suspend in suspend_noirq(device_suspend_noirq->
> __device_suspend_noirq) phase.
> As a device failed in dpm_noirq_suspend_devices phase, dpm_resume_noirq is
> getting called to resume devices in dpm_late_early_list in the noirq phase.
>
> 4) During the Devices_early_resume stage
> dpm_resume_early()-->device_resume_early() functions skipping the devices
> early resume callbacks.
> 799 if (dev_pm_skip_resume(dev))
> 800 goto Skip;
>
> 5) Devices suspended in suspend_late stage are not getting resumed in
> Devices_early_resume stage because of
> 'commit 6e176bf8d461 ("PM: sleep: core: Do not skip callbacks in the resume phase")'
> is skipping the driver early_resume callbacks when dev->power.must_resume is false.
>
>
> Changelog:
> v1 -> v2:
> - Fixed indentation comments.
> - Commit text updated to include scenario.
>
> Prasad Sodagudi (1):
> PM: sleep: core: Avoid setting power.must_resume to false
>
> drivers/base/power/main.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
I do not see a patch here, what happened?
:(
next prev parent reply other threads:[~2021-08-10 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 13:42 [PATCH v2] PM: sleep: core: Avoid setting power.must_resume to false Prasad Sodagudi
2021-08-10 13:42 ` Prasad Sodagudi
2021-08-10 15:05 ` Greg KH
2021-08-10 15:06 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-08-10 13:54 Prasad Sodagudi
2021-08-10 13:54 ` Prasad Sodagudi
2021-08-07 6:00 [PATCH] " Greg KH
2021-08-08 16:10 ` [PATCH v2] " Prasad Sodagudi
2021-08-08 17:36 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRKV3aYPvQhkL/9m@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=psodagud@codeaurora.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).