From: Christoph Hellwig <hch@infradead.org>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: rppt@kernel.org, bp@alien8.de, tglx@linutronix.de,
x86@kernel.org, pjones@redhat.com, konrad@kernel.org,
george.kennedy@oracle.com, rafael@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] iscsi_ibft: fix crash due to KASLR physical memory remapping
Date: Tue, 10 Aug 2021 18:00:24 +0100 [thread overview]
Message-ID: <YRKwqAlgWVGVpEJv@infradead.org> (raw)
In-Reply-To: <20210729135250.32212-1-mlombard@redhat.com>
> Fix this bug by saving the address of the physical location
> of the ibft; later the driver will use isa_bus_to_virt() to get
> the correct virtual address.
That sound rather broken. Why not save the physical address in
find_ibft_region and then later ioremap that when a virtual address is
needed like all other code accessing magic I/O memory?
next prev parent reply other threads:[~2021-08-10 17:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 13:52 Maurizio Lombardi
2021-07-29 17:03 ` Konrad Rzeszutek Wilk
2021-07-29 19:20 ` Maurizio Lombardi
2021-07-29 19:31 ` Mike Rapoport
2021-08-01 2:44 ` Konrad Rzeszutek Wilk
2021-08-10 17:00 ` Christoph Hellwig [this message]
2021-08-10 17:55 ` Konrad Rzeszutek Wilk
2021-08-11 6:57 ` Christoph Hellwig
2021-08-11 7:20 ` Mike Rapoport
2021-09-01 16:47 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRKwqAlgWVGVpEJv@infradead.org \
--to=hch@infradead.org \
--cc=bp@alien8.de \
--cc=george.kennedy@oracle.com \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlombard@redhat.com \
--cc=pjones@redhat.com \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--subject='Re: [PATCH V3] iscsi_ibft: fix crash due to KASLR physical memory remapping' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).