From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58472C4338F for ; Tue, 10 Aug 2021 19:02:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AA2560F56 for ; Tue, 10 Aug 2021 19:02:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232267AbhHJTCo (ORCPT ); Tue, 10 Aug 2021 15:02:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22997 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232180AbhHJTCg (ORCPT ); Tue, 10 Aug 2021 15:02:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628622133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nios0x/SOmEoWSIl8z+EuMVv3qi92+eLAcRIOjO/f+w=; b=LM7a1guaiPcsDnPyyyFEJ9ohdNBeTtzv0+l+UotGZFEKV9k/gtsqtP6Sp/PWwVIrYiScmo pFcuyAdie3jApKhRsuHZXzzhoO0DI0w3ku4GtzcFH6X8yyVIN7Uqg5iZy5FTClDL9xsHhV QmE/8+x5R91sAY1PkHKBdr9WXfMCdMQ= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-185-b8m4rov_NvaLdLKHOs-ubw-1; Tue, 10 Aug 2021 15:02:12 -0400 X-MC-Unique: b8m4rov_NvaLdLKHOs-ubw-1 Received: by mail-qk1-f197.google.com with SMTP id q11-20020a05620a05abb02903ca17a8eef8so14542121qkq.10 for ; Tue, 10 Aug 2021 12:02:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nios0x/SOmEoWSIl8z+EuMVv3qi92+eLAcRIOjO/f+w=; b=cxjm/J9rfDPLmjqV0vT9htCeD8V14LnRJNpSpJMGKz4TKLGZDiwcQEOa/n5s28zaoP IK++6HBZaj//eumdQjECCpYN1sCbxMxiYdZ8wFVnn/Xxo1HHb61tELyPUDPcf+C/Fh8I 6HYouOmgZ9heJDS+s8ZGX+JSIifsN6Renq1qzeXhz7k5+jWJj2cwI+utX5lQiXr3Bsxc x47L/42OCUlmhnCgASeX9RNlyONWX4UKILkymInuAdGyrs8ribE0rY8szw7DQ1AwIMvb OmXgwK4arlhRpfwMzd1AF8vrHb0g7GOGMcz88hWwLdl/nJ5A2vHUqRLYkyvtwp3ct4H9 q/bQ== X-Gm-Message-State: AOAM530OYj7iunEZhX+YnfookwPnCbnRSdSuCszKfXV9B9OuodWkaqOW MEe3YegH4u3tmhBg3weBlutgZxWrCG9TrbXnuoAbIGoCuX3mTZ7zOgjo1j88kd5SNo4iVLSmEQh jUb6PlChbgaH5jaxiqmdqoyAe X-Received: by 2002:ad4:4ee5:: with SMTP id dv5mr19515001qvb.3.1628622132276; Tue, 10 Aug 2021 12:02:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqt+5uYfshgiH7+DypABuSliS1cOfcGFcYlN+d70O9IJB9ST177nPLHh0DQzpOAn2Xszyk0Q== X-Received: by 2002:ad4:4ee5:: with SMTP id dv5mr19514951qvb.3.1628622131763; Tue, 10 Aug 2021 12:02:11 -0700 (PDT) Received: from t490s (bras-base-toroon474qw-grc-92-76-70-75-133.dsl.bell.ca. [76.70.75.133]) by smtp.gmail.com with ESMTPSA id g1sm11333268qkd.89.2021.08.10.12.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 12:02:10 -0700 (PDT) Date: Tue, 10 Aug 2021 15:02:10 -0400 From: Peter Xu To: Christoph Hellwig Cc: Alex Williamson , Jason Gunthorpe , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH 3/7] vfio/pci: Use vfio_device_unmap_mapping_range() Message-ID: References: <162818167535.1511194.6614962507750594786.stgit@omen> <162818325518.1511194.1243290800645603609.stgit@omen> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 10, 2021 at 10:53:50AM +0200, Christoph Hellwig wrote: > On Thu, Aug 05, 2021 at 11:07:35AM -0600, Alex Williamson wrote: > > +static void vfio_pci_zap_bars(struct vfio_pci_device *vdev) > > { > > + vfio_device_unmap_mapping_range(&vdev->vdev, > > + VFIO_PCI_INDEX_TO_OFFSET(VFIO_PCI_BAR0_REGION_INDEX), > > + VFIO_PCI_INDEX_TO_OFFSET(VFIO_PCI_ROM_REGION_INDEX) - > > + VFIO_PCI_INDEX_TO_OFFSET(VFIO_PCI_BAR0_REGION_INDEX)); > > Maybe make this a little more readable by having local variables: Or just pass in unmap_mapping_range(start=0, len=0)? As unmap_mapping_range() understands len==0 as "to the end of file". Thanks, -- Peter Xu