From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B9EC432BE for ; Tue, 10 Aug 2021 23:11:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F8A1601FD for ; Tue, 10 Aug 2021 23:11:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235338AbhHJXLh (ORCPT ); Tue, 10 Aug 2021 19:11:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235310AbhHJXLf (ORCPT ); Tue, 10 Aug 2021 19:11:35 -0400 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49F78C061765 for ; Tue, 10 Aug 2021 16:11:13 -0700 (PDT) Received: by mail-ot1-x330.google.com with SMTP id r16-20020a0568304190b02904f26cead745so1081038otu.10 for ; Tue, 10 Aug 2021 16:11:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6k/wx6m+QJ/KlUp48PSjkqVXsVZIRjT7zgrmzwo+LyQ=; b=OJMoA75yQfF6nIJT4ewyNMLTnvWZOgMWN8T989A9NATkVmWkcvEHkZ//Bbn/zE9y5K Z1Uispq+zjpJYh98KfUHe2JqgRI8s9r8zjUtY4VEagIcHTLQwR4ERyUWOrxTJP4lSeoN CyWrshuezwqkzMkQND0H44Am2oxZs7sJ+23nOp9WHQ3Tgg4nBnUpNlorVEERJEiBxOrt sr4IaD0me6krumvAf7VrApwnuiE/br4ETEzZTMqne1qiycmW6vPyQXfTvK7SfOUQB4uo ulurrn3w4C/7oWPbzBP/asuwu5bgTiDbiBybFldqv5zfKX7v7h38qWUKLk/TSpyYmFYw 5f2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6k/wx6m+QJ/KlUp48PSjkqVXsVZIRjT7zgrmzwo+LyQ=; b=uTGhDB5W/TfpEwnvtONt5zQomquzsER1WcOSc8wICf7kU/GrqsdFAK+7rTbztX3hzV 7Bbzool8wCLnup1Ow6U35AyAkkrxDY2CF5B17Zl7X4ZU0YPQ1XxFCrTwVHuU+cEDTT2a yZfotTuhWzOrK8PZ2fr0tZQgBR3Rp/v+vXxPKqqOYvjR7/zG+XkBjGlpzwRMbFraV2vq DLKiBXK4Xr2Ua302lQh6F+uPfzUM0DgehS21IehUV0iCdqoE9Y5X8TaSyINn1EgWzPVE sJFNFPD6y+MS4IrGXvbDZAp6dfNY41N/wQHfVCyfHHn2jQVbJ0aFfNQEJj3GQ4P40W+t pKuQ== X-Gm-Message-State: AOAM533KxXwz4TupYnDvCXfw5pQ8rJ+v8HR8yP2AxC31o4R7+1pCpptk oppqJ16AbhNTwe6Cp+WE3LCcXg== X-Google-Smtp-Source: ABdhPJxorQVOzl3SFtPyjfr0z3XLe0f2nbmj0FKS3FiM+slX5zDmMsJ6o4Dlo0xQzYOLfYQRmQsFIQ== X-Received: by 2002:a9d:7651:: with SMTP id o17mr22363483otl.205.1628637072682; Tue, 10 Aug 2021 16:11:12 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id k26sm2359920otb.53.2021.08.10.16.11.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 16:11:12 -0700 (PDT) Date: Tue, 10 Aug 2021 18:11:10 -0500 From: Bjorn Andersson To: Stephen Boyd Cc: Sibi Sankar , Deepak Kumar Singh , clew@codeaurora.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, Andy Gross Subject: Re: [PATCH V1 1/1] soc: qcom: smp2p: Add wakeup capability to SMP2P IRQ Message-ID: References: <1628180254-758-1-git-send-email-deesin@codeaurora.org> <8009f5a1458468dbf0b7b20dd166911c@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 10 Aug 14:18 CDT 2021, Stephen Boyd wrote: > Quoting Sibi Sankar (2021-08-10 10:24:32) > > On 2021-08-09 23:28, Stephen Boyd wrote: > > > Quoting Deepak Kumar Singh (2021-08-09 04:05:08) > > >> > > >> On 8/6/2021 1:10 AM, Stephen Boyd wrote: > > >> > Quoting Deepak Kumar Singh (2021-08-05 09:17:33) > > >> >> Some use cases require SMP2P interrupts to wake up the host > > >> >> from suspend. > > >> > Please elaborate on this point so we understand what sort of scenarios > > >> > want to wakeup from suspend. > > >> > > >> Once such scenario is where WiFi/modem crashes and notifies crash to > > >> local host through smp2p > > >> > > >> if local host is in suspend it should wake up to handle the crash and > > >> reboot the WiFi/modem. > > > > > > Does anything go wrong if the firmware crashes during suspend and the > > > local host doesn't handle it until it wakes for some other reason? I'd > > > like to understand if the crash handling can be delayed/combined with > > > another wakeup. > > > > If the modem firmware crashes > > during suspend, the system comes > > out of xo-shutdown and AFAIK stays > > there until we handle the interrupt. > > > > So you're saying we waste power if we don't wakeup the AP and leave the > SoC in a shallow low power state? That would be good to have indicated > in the code via a comment and in the commit text so we know that we want > to handle the wakeup by default. Sounds like in a system without autosleep (or userspace equivalent) it would be desirable to leave the SoC in this lower state than to wake up the system handle the crash and then just idle? But leaving the system in this state will result in you missing your important phone calls... Regards, Bjorn