From: Christoph Hellwig <hch@infradead.org>
To: luomeng <luomeng12@huawei.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
axboe@kernel.dk, hare@suse.de, bvanassche@acm.org,
ming.lei@redhat.com, hch@infradead.org, jack@suse.cz,
osandov@fb.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] block: replace incorrect uses of GENHD_FL_UP
Date: Wed, 11 Aug 2021 06:19:28 +0100 [thread overview]
Message-ID: <YRNd4O1uV1auj/pK@infradead.org> (raw)
In-Reply-To: <051ab019-5163-e691-43ed-052401b6b95a@huawei.com>
On Wed, Aug 11, 2021 at 10:42:20AM +0800, luomeng wrote:
> Hi:
> When the fuzz test injected memory allocation failed, I had this BUG_ON:
> kernel BUG at fs/sysfs/group.c:116.
> The cause of the bug_ON is that the add_disk memory fails to be allocated
> but no error processing is performed.
> I find your patches add error processing. So what is your next step with
> these patches.
I have one more pending series on top of this one I need to submit here:
http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/alloc_disk
to make sure the disk always has a valid queue reference. After that
Luis work to return an error from add_disk should be much easier bause
we not have defined state.
next prev parent reply other threads:[~2021-08-11 5:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 18:20 [PATCH 0/5] block: replace incorrect uses of GENHD_FL_UP Luis Chamberlain
2021-07-20 18:20 ` [PATCH 1/5] block: add flag for add_disk() completion notation Luis Chamberlain
2021-07-21 4:59 ` Christoph Hellwig
2021-07-20 18:20 ` [PATCH 2/5] md: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED on is_mddev_broken() Luis Chamberlain
2021-07-21 5:03 ` Christoph Hellwig
2021-07-20 18:20 ` [PATCH 3/5] mmc/core/block: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED Luis Chamberlain
2021-07-21 5:23 ` Christoph Hellwig
2021-07-20 18:20 ` [PATCH 4/5] nvme: " Luis Chamberlain
2021-07-21 5:31 ` Christoph Hellwig
2021-07-20 18:20 ` [PATCH 5/5] fs/block_dev: " Luis Chamberlain
2021-07-21 5:25 ` Christoph Hellwig
2021-08-11 2:42 ` [PATCH 0/5] block: replace incorrect uses of GENHD_FL_UP luomeng
2021-08-11 5:19 ` Christoph Hellwig [this message]
2021-08-12 2:07 ` luomeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRNd4O1uV1auj/pK@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luomeng12@huawei.com \
--cc=mcgrof@kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).