From: Greg KH <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
phil@philpotter.co.uk, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] staging: r8188eu: Remove wrapper around vfree
Date: Wed, 11 Aug 2021 18:45:55 +0200 [thread overview]
Message-ID: <YRP+wz05avsLx3EN@kroah.com> (raw)
In-Reply-To: <20210811154412.GA1005754@roeck-us.net>
On Wed, Aug 11, 2021 at 08:44:12AM -0700, Guenter Roeck wrote:
> On Mon, Aug 02, 2021 at 02:27:17PM -0500, Larry Finger wrote:
> > This call is so simple that there is no need, or use, for a wrapper.
> >
>
> Except the wrapper was presumably there to map generic code to Linux
> code, and the patch doesn't add an include <linux/vmalloc.h> anywhere.
> This results in widespread build errrors such as
>
> drivers/staging/r8188eu/core/rtw_mlme.c: In function '_rtw_free_mlme_priv':
> drivers/staging/r8188eu/core/rtw_mlme.c:129:17: error: implicit declaration of function 'vfree'
>
> for all architectures where <linux/vmalloc.h> isn't included indirectly.
Has now been fixed up in my tree and will show up in the next
linux-next.
sorry about that,
greg k-h
next prev parent reply other threads:[~2021-08-11 16:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 19:27 [PATCH v2 0/6] Clean up some extraneous wrappers and some empty routines Larry Finger
2021-08-02 19:27 ` [PATCH v2 1/6] staging: r8188eu: Remove wrappers for kalloc() and kzalloc() Larry Finger
2021-08-05 10:52 ` Greg KH
2021-08-02 19:27 ` [PATCH v2 2/6] staging: r8188eu: Remove wrapper around vfree Larry Finger
2021-08-11 15:44 ` Guenter Roeck
2021-08-11 16:45 ` Greg KH [this message]
2021-08-02 19:27 ` [PATCH v2 3/6] staging: r8188eu: Remove wrappers for atomic operations Larry Finger
2021-08-02 19:27 ` [PATCH v2 4/6] staging: r8188eu: Remove 4 empty routines from os_sep/service.c Larry Finger
2021-08-02 19:27 ` [PATCH v2 5/6] staging: r8188eu: Remove all calls to _rtw_spinlock_free() Larry Finger
2021-08-02 19:27 ` [PATCH v2 6/6] staging: r8188eu: Remove more empty routines Larry Finger
2021-08-05 10:53 ` [PATCH v2 0/6] Clean up some extraneous wrappers and some " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRP+wz05avsLx3EN@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@roeck-us.net \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).