From: Ido Schimmel <idosch@idosch.org>
To: DENG Qingfang <dqfext@gmail.com>
Cc: Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"moderated list:ETHERNET BRIDGE"
<bridge@lists.linux-foundation.org>,
"open list:ETHERNET BRIDGE" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [PATCH net-next] net: bridge: switchdev: allow port isolation to be offloaded
Date: Thu, 12 Aug 2021 00:38:56 +0300 [thread overview]
Message-ID: <YRRDcGWaWHgBkNhQ@shredder> (raw)
In-Reply-To: <20210811135247.1703496-1-dqfext@gmail.com>
On Wed, Aug 11, 2021 at 09:52:46PM +0800, DENG Qingfang wrote:
> Add BR_ISOLATED flag to BR_PORT_FLAGS_HW_OFFLOAD, to allow switchdev
> drivers to offload port isolation.
>
> Suggested-by: Vladimir Oltean <olteanv@gmail.com>
> Signed-off-by: DENG Qingfang <dqfext@gmail.com>
> ---
> net/bridge/br_switchdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c
> index 6bf518d78f02..898257153883 100644
> --- a/net/bridge/br_switchdev.c
> +++ b/net/bridge/br_switchdev.c
> @@ -71,7 +71,8 @@ bool nbp_switchdev_allowed_egress(const struct net_bridge_port *p,
>
> /* Flags that can be offloaded to hardware */
> #define BR_PORT_FLAGS_HW_OFFLOAD (BR_LEARNING | BR_FLOOD | \
> - BR_MCAST_FLOOD | BR_BCAST_FLOOD)
> + BR_MCAST_FLOOD | BR_BCAST_FLOOD | \
> + BR_ISOLATED)
Why add it now and not as part of a patchset that actually makes use of
the flag in a driver that offloads port isolation?
>
> int br_switchdev_set_port_flag(struct net_bridge_port *p,
> unsigned long flags,
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-08-11 21:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 13:52 [PATCH net-next] net: bridge: switchdev: allow port isolation to be offloaded DENG Qingfang
2021-08-11 21:38 ` Ido Schimmel [this message]
2021-08-11 21:45 ` Vladimir Oltean
2021-08-11 21:52 ` Ido Schimmel
2021-08-11 21:58 ` Vladimir Oltean
2021-08-12 6:04 ` DENG Qingfang
2021-08-12 10:17 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRRDcGWaWHgBkNhQ@shredder \
--to=idosch@idosch.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=olteanv@gmail.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).