From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Ben Gardon <bgardon@google.com>
Subject: Re: [PATCH 1/2] KVM: x86/mmu: Don't skip non-leaf SPTEs when zapping all SPTEs
Date: Thu, 12 Aug 2021 16:43:48 +0000 [thread overview]
Message-ID: <YRVPxCv2RtyXi+XO@google.com> (raw)
In-Reply-To: <01b22936-49b0-638e-baf8-269ba93facd8@redhat.com>
On Thu, Aug 12, 2021, Paolo Bonzini wrote:
> On 12/08/21 07:07, Sean Christopherson wrote:
> > @@ -739,8 +749,16 @@ static bool zap_gfn_range(struct kvm *kvm, struct kvm_mmu_page *root,
> > gfn_t start, gfn_t end, bool can_yield, bool flush,
> > bool shared)
> > {
> > + bool zap_all = (end == ZAP_ALL_END);
> > struct tdp_iter iter;
> > + /*
> > + * Bound the walk at host.MAXPHYADDR, guest accesses beyond that will
> > + * hit a #PF(RSVD) and never get to an EPT Violation/Misconfig / #NPF,
> > + * and so KVM will never install a SPTE for such addresses.
> > + */
> > + end = min(end, 1ULL << (shadow_phys_bits - PAGE_SHIFT));
>
> Then zap_all need not have any magic value. You can use 0/-1ull, it's
> readable enough. ZAP_ALL_END is also unnecessary here if you do:
>
> gfn_t max_gfn_host = 1ULL << (shadow_phys_bits - PAGE_SHIFT);
> bool zap_all = (start == 0 && end >= max_gfn_host);
Aha! Nice. I was both too clever and yet not clever enough.
> end = min(end, max_gfn_host);
>
> And as a small commit message nit, I would say "don't leak" instead of
> "don't skip", since that's really the effect.
Hrm, yeah, I can see how "skip" doesn't raise alarm bells like it should.
next prev parent reply other threads:[~2021-08-12 16:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 5:07 [PATCH 0/2] KVM: x86/mmu: Fix a TDP MMU leak and optimize zap all Sean Christopherson
2021-08-12 5:07 ` [PATCH 1/2] KVM: x86/mmu: Don't skip non-leaf SPTEs when zapping all SPTEs Sean Christopherson
2021-08-12 16:18 ` Paolo Bonzini
2021-08-12 16:43 ` Sean Christopherson [this message]
2021-08-12 18:09 ` Sean Christopherson
2021-08-12 5:07 ` [PATCH 2/2] KVM: x86/mmu: Don't step down in the TDP iterator " Sean Christopherson
2021-08-12 16:47 ` Ben Gardon
2021-08-12 17:07 ` Sean Christopherson
2021-08-12 17:15 ` Paolo Bonzini
2021-08-12 17:33 ` Sean Christopherson
2021-08-12 17:38 ` Paolo Bonzini
2021-08-12 17:46 ` Sean Christopherson
2021-08-13 7:27 ` Paolo Bonzini
2021-08-13 16:13 ` Sean Christopherson
2021-08-13 16:38 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRVPxCv2RtyXi+XO@google.com \
--to=seanjc@google.com \
--cc=bgardon@google.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).