linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Anand Jain <anand.jain@oracle.com>
Cc: Qu Wenruo <wqu@suse.com>, Qu Wenruo <quwenruo.btrfs@gmx.com>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	linux-btrfs@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>
Subject: Re: [PATCH 4/7] btrfs: qgroup: try to flush qgroup space when we get -EDQUOT
Date: Fri, 13 Aug 2021 12:56:32 +0200	[thread overview]
Message-ID: <YRZP4Jh0FNHrma5/@kroah.com> (raw)
In-Reply-To: <26649302-ce62-798d-4a9c-6a46ab1e25ec@oracle.com>

On Fri, Aug 13, 2021 at 06:41:53PM +0800, Anand Jain wrote:
> 
> 
> On 13/08/2021 18:39, Qu Wenruo wrote:
> > 
> > 
> > On 2021/8/13 下午6:30, Anand Jain wrote:
> > > 
> > > 
> > > On 13/08/2021 18:26, Qu Wenruo wrote:
> > > > 
> > > > 
> > > > On 2021/8/13 下午5:55, Anand Jain wrote:
> > > > > From: Qu Wenruo <wqu@suse.com>
> > > > > 
> > > > > commit c53e9653605dbf708f5be02902de51831be4b009 upstream
> > > > 
> > > > This lacks certain upstream fixes for it:
> > > > 
> > > > f9baa501b4fd6962257853d46ddffbc21f27e344 btrfs: fix deadlock when
> > > > cloning inline extents and using qgroups
> > > > 
> > > > 4d14c5cde5c268a2bc26addecf09489cb953ef64 btrfs: don't flush from
> > > > btrfs_delayed_inode_reserve_metadata
> > > > 
> > > > 6f23277a49e68f8a9355385c846939ad0b1261e7 btrfs: qgroup: don't commit
> > > > transaction when we already hold the handle
> > > > 
> > > > All these fixes are to ensure we don't try to flush in context where we
> > > > shouldn't.
> > > > 
> > > > Without them, it can hit various deadlock.
> > > > 
> > > 
> > > Qu,
> > > 
> > >     Thanks for taking a look. I will send it in v2.
> > 
> > I guess you only need to add the missing fixes?
> 
>   Yeah, maybe it's better to send it as a new set.

So should I drop the existing patches and wait for a whole new series,
or will you send these as an additional set?

And at least one of the above commits needs to go to the 5.10.y tree, I
did not check them all...

thanks,

greg k-h

  reply	other threads:[~2021-08-13 10:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13  9:55 [PATCH 0/7] make btrfs/153 sucessful on 5.4.y Anand Jain
2021-08-13  9:55 ` [PATCH 1/7] btrfs: make qgroup_free_reserved_data take btrfs_inode Anand Jain
2021-08-13  9:55 ` [PATCH 2/7] btrfs: make btrfs_qgroup_reserve_data " Anand Jain
2021-08-13  9:55 ` [PATCH 3/7] btrfs: qgroup: allow to unreserve range without releasing other ranges Anand Jain
2021-08-13  9:55 ` [PATCH 4/7] btrfs: qgroup: try to flush qgroup space when we get -EDQUOT Anand Jain
2021-08-13 10:26   ` Qu Wenruo
2021-08-13 10:30     ` Anand Jain
2021-08-13 10:39       ` Qu Wenruo
2021-08-13 10:41         ` Anand Jain
2021-08-13 10:56           ` Greg KH [this message]
2021-08-13 11:06             ` Anand Jain
2021-08-30 22:27               ` Anand Jain
2021-08-13  9:55 ` [PATCH 5/7] btrfs: transaction: Cleanup unused TRANS_STATE_BLOCKED Anand Jain
2021-08-13  9:55 ` [PATCH 6/7] btrfs: qgroup: remove ASYNC_COMMIT mechanism in favor of reserve retry-after-EDQUOT Anand Jain
2021-08-13  9:55 ` [PATCH 7/7] btrfs: fix lockdep splat when enabling and disabling qgroups Anand Jain
2021-08-13 10:18 ` [PATCH 0/7] make btrfs/153 sucessful on 5.4.y Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRZP4Jh0FNHrma5/@kroah.com \
    --to=greg@kroah.com \
    --cc=anand.jain@oracle.com \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=stable@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).