From: Alyssa Rosenzweig <alyssa@rosenzweig.io>
To: Sven Peter <sven@svenpeter.dev>
Cc: linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Stan Skowronek" <stan@corellium.com>,
"Marc Zyngier" <maz@kernel.org>,
"Mark Kettenis" <kettenis@openbsd.org>,
"Hector Martin" <marcan@marcan.st>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] PCI: apple: Add driver for the Apple M1
Date: Sun, 15 Aug 2021 17:40:09 -0400 [thread overview]
Message-ID: <YRmJucYuL0T93huV@sunset> (raw)
In-Reply-To: <fb037103-66d5-477f-ba2e-03da74da97c0@www.fastmail.com>
> > +/* The hardware exposes 3 ports. Port 0 (WiFi and Bluetooth) is
> > special, as it
> > + * is power-gated by SMC to facilitate rfkill.
> > + */
> > +enum apple_pcie_port {
> > + APPLE_PCIE_PORT_RADIO = 0,
> > + APPLE_PCIE_PORT_USB = 1,
> > + APPLE_PCIE_PORT_ETHERNET = 2,
> > + APPLE_PCIE_NUM_PORTS
> > +};
>
> This will also be used for the Thunderbolt ports, where this enum
> won't apply at all. I could also see Apple changing the individual port
> assignments in the future. I'd just remove it here and have this file be
> a generic PCIe driver for Apple SoCs.
Removed in v2.
> As above, I don't think it makes sense to special-case anything for the
> devices on the bus here. These controllers also have hot plug support,
> so the radios don't have to be on by the time it's initialized.
> We could also just turn them on in the bootloader for now.
This should be fixed in v2 with Mark's device tree bindings.
next prev parent reply other threads:[~2021-08-16 3:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-15 4:25 [RFC PATCH 0/2] Add PCI driver for the Apple M1 Alyssa Rosenzweig
2021-08-15 4:25 ` [RFC PATCH 1/2] dt-bindings: PCI: Add Apple PCI controller Alyssa Rosenzweig
2021-08-15 7:09 ` Marc Zyngier
[not found] ` <1566004903.6140692.1629015053757@ox-webmail.xs4all.nl>
2021-08-15 9:12 ` Marc Zyngier
2021-08-16 1:34 ` Alyssa Rosenzweig
2021-08-22 18:03 ` Mark Kettenis
2021-08-15 4:25 ` [RFC PATCH 2/2] PCI: apple: Add driver for the Apple M1 Alyssa Rosenzweig
2021-08-15 7:42 ` Marc Zyngier
2021-08-15 9:19 ` Marc Zyngier
2021-08-16 1:45 ` Alyssa Rosenzweig
2021-08-15 12:33 ` Sven Peter
2021-08-15 16:49 ` Marc Zyngier
2021-08-16 6:37 ` Sven Peter
2021-08-18 11:43 ` Hector Martin
2021-08-18 14:22 ` Mark Kettenis
2021-08-16 1:31 ` Alyssa Rosenzweig
2021-08-16 21:56 ` Marc Zyngier
2021-08-17 7:34 ` Arnd Bergmann
2021-08-17 8:12 ` Marc Zyngier
2021-08-17 7:35 ` Sven Peter
2021-08-15 7:43 ` Sven Peter
2021-08-15 21:40 ` Alyssa Rosenzweig [this message]
2021-08-15 20:57 ` Rob Herring
2021-08-15 21:33 ` Alyssa Rosenzweig
[not found] ` <CAHp75VeKeGgUgALLztA3Q3jizF2=OkSzU9bzaPmTHO9Pad=QOQ@mail.gmail.com>
2021-08-16 3:20 ` Alyssa Rosenzweig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRmJucYuL0T93huV@sunset \
--to=alyssa@rosenzweig.io \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kettenis@openbsd.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marcan@marcan.st \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=stan@corellium.com \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).