From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 264B5C4338F for ; Mon, 16 Aug 2021 03:18:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D8A3617E3 for ; Mon, 16 Aug 2021 03:18:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232875AbhHPDS7 (ORCPT ); Sun, 15 Aug 2021 23:18:59 -0400 Received: from [138.197.143.207] ([138.197.143.207]:45336 "EHLO rosenzweig.io" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S232249AbhHPDSw (ORCPT ); Sun, 15 Aug 2021 23:18:52 -0400 Date: Sun, 15 Aug 2021 21:34:36 -0400 From: Alyssa Rosenzweig To: Marc Zyngier Cc: linux-pci@vger.kernel.org, Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Stan Skowronek , Mark Kettenis , Sven Peter , Hector Martin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/2] dt-bindings: PCI: Add Apple PCI controller Message-ID: References: <20210815042525.36878-1-alyssa@rosenzweig.io> <20210815042525.36878-2-alyssa@rosenzweig.io> <87bl5z18vt.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bl5z18vt.wl-maz@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marc, > > Document the properties used by the Apple PCI controller. This is a > > fairly standard PCI controller, although it is not derived from any > > known non-Apple IP. > > > > Signed-off-by: Alyssa Rosenzweig > > I would rather you post something as an extension to Mark's work, for > multiple reasons: > > - Mark's patch is still being discussed, and is the current > reference (specially given that it is already in use in OpenBSD and > u-boot). > > - we cannot have multiple bindings. There can only be one, shared > across implementations. Otherwise, you need a different kernel > depending on whether you are booting from m1n1 or u-boot. > > - what you have here is vastly inconsistent (you are describing the > MSIs twice, using two different methods). Absolutely agree, the frankenstein bindings here were the main reason v1 was marked RFC. For v2, I've rebased on Mark's patch, which makes a bunch of driver magic disappear. Alyssa