From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 114B9C432BE for ; Mon, 16 Aug 2021 04:10:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8B716128E for ; Mon, 16 Aug 2021 04:10:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229975AbhHPEL1 (ORCPT ); Mon, 16 Aug 2021 00:11:27 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:51276 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229550AbhHPEL0 (ORCPT ); Mon, 16 Aug 2021 00:11:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=lnFC0mcTrtftt9YUv/VHE4sLvFQC1IIrfw3meEGyAAU=; b=zQ2NTxhnkMfWvqO3fSzkZiT/hY DGU+uN71Xlqihw5v+XJ3VS7F9Uk+btqKVn1Q6WDYl1x1AjxalZ5+orSd6i0RuesLU7p3/NN49rjGp 9aSyPa3dPS+WRa5/yLuWt8GZvqf7aNHX55deRj4Q182+g+ZxIND+tuRbI8bqI4hMgbC0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mFTxP-000KlX-Qm; Mon, 16 Aug 2021 06:10:39 +0200 Date: Mon, 16 Aug 2021 06:10:39 +0200 From: Andrew Lunn To: "Song, Yoong Siang" Cc: "Russell King (Oracle)" , Marek =?iso-8859-1?Q?Beh=FAn?= , Heiner Kallweit , "David S . Miller" , Jakub Kicinski , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next 1/1] net: phy: marvell10g: Add WAKE_PHY support to WOL event Message-ID: References: <20210813084536.182381-1-yoong.siang.song@intel.com> <20210814172656.GA22278@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 16, 2021 at 03:19:34AM +0000, Song, Yoong Siang wrote: > > > How does this work if the driver has no interrupt support? What is the > > > hardware setup this has been tested with? > > > > Hi Russell > > > > We already know from previous patches that the Intel hardware is broken, > > and does not actually deliver the interrupt which caused the wake up. So i > > assume this just continues on with the same broken hardware, but they have > > a different PHY connected. > > Hi Russell & Andrew, > > This is tested on Intel Elkhart Lake (EHL) board. We are using polling mode. > Both WoL interrupt and link change interrupt are the same pin which is > routed to PMC. PMC will wake up the system when there is WoL event. Is the PMC also an interrupt controller? Andrew