From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F6F8C4338F for ; Mon, 16 Aug 2021 15:01:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D6A861029 for ; Mon, 16 Aug 2021 15:01:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232432AbhHPPBh (ORCPT ); Mon, 16 Aug 2021 11:01:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:54534 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229586AbhHPPBg (ORCPT ); Mon, 16 Aug 2021 11:01:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 87BCA60C3F; Mon, 16 Aug 2021 15:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1629126065; bh=BbMCr1w/Hongz20Hd6ukvY3O6D1eg3r8Timq5lfmDzw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dcKxIx5DxjH0LIjpcd5U4Bp8a9YXLLAcNK/oGoaNC3t/+6xHrYVppP7buyX8qfCXT 7m9LbZUHH8EIvtk/vAWgNsk6ZEMB71fIzNrOVmcMTmZ2YbK8Z3QXFopR8wCNe+Ypjg XrZTM+5V5To9v9SNoalp82RpcvNwHyfXeApzYCG4= Date: Mon, 16 Aug 2021 17:01:02 +0200 From: Greg Kroah-Hartman To: Alex Elder Cc: "Fabio M. De Francesco" , Johan Hovold , Alex Elder , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH v2] staging: greybus: Convert uart.c from IDR to XArray Message-ID: References: <20210814181130.21383-1-fmdefrancesco@gmail.com> <5541b638-db1e-26f2-2682-81f35504c9a3@ieee.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5541b638-db1e-26f2-2682-81f35504c9a3@ieee.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 16, 2021 at 09:46:08AM -0500, Alex Elder wrote: > On 8/14/21 1:11 PM, Fabio M. De Francesco wrote: > > Convert greybus/uart.c from IDR to XArray. The abstract data type XArray > > is more memory-efficient, parallelisable, and cache friendly. It takes > > advantage of RCU to perform lookups without locking. Furthermore, IDR is > > deprecated because XArray has a better (cleaner and more consistent) API. > > I haven't verified the use of the new API (yet) but I have a few > comments on your patch, below. > > -Alex > > > Reported-by: kernel test robot > > Signed-off-by: Fabio M. De Francesco > > I'm not sure I'm right about this... But the actual change you're > making has nothing to do with what the Intel test robot reported. > I personally find the "Reported-by" here a little misleading, but > maybe the "Link" line that gets added will provide explanation. > > Anyway, unless someone else contradicts/corrects me, I'd rather > not have the "Reported-by" here (despite wanting to provide much > credit to ...). You are correct, "Reported-by:" does not make sense here. thanks, greg k-h