From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: David Thompson <davthompson@nvidia.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Asmaa Mnebhi <asmaa@nvidia.com>, Liming Sun <limings@nvidia.com>
Subject: Re: [PATCH v1 6/6] TODO: net: mellanox: mlxbf_gige: Replace non-standard interrupt handling
Date: Tue, 17 Aug 2021 12:05:14 +0300 [thread overview]
Message-ID: <YRt7yqoukWSYmHMg@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkdavU=_Fo3DQkD_MAT9Ur-RX46v0L-O=tqibpUtdUhe-NA@mail.gmail.com>
On Tue, Aug 17, 2021 at 01:06:06AM +0200, Linus Walleij wrote:
> On Mon, Aug 16, 2021 at 2:00 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>
> > Since GPIO driver supports interrupt handling, replace custom routine with
> > simple IRQ request.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > .../mellanox/mlxbf_gige/mlxbf_gige_gpio.c | 212 ------------------
>
> Don't you also need to remove this file from Makefile?
Of course, this is simply to show the intention. It's just a hint, I have no
time to write the code for Mellanox, really :-)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-08-17 9:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 11:59 [PATCH v1 0/6] gpio: mlxbf2: Introduce proper interrupt handling Andy Shevchenko
2021-08-16 11:59 ` [PATCH v1 1/6] gpio: mlxbf2: Convert to device PM ops Andy Shevchenko
2021-08-16 13:04 ` Asmaa Mnebhi
2021-08-16 11:59 ` [PATCH v1 2/6] gpio: mlxbf2: Drop wrong use of ACPI_PTR() Andy Shevchenko
2021-08-16 13:05 ` Asmaa Mnebhi
2021-08-16 19:20 ` Bartosz Golaszewski
2021-08-16 19:33 ` Andy Shevchenko
2021-08-16 11:59 ` [PATCH v1 3/6] gpio: mlxbf2: Use devm_platform_ioremap_resource() Andy Shevchenko
2021-08-16 13:05 ` Asmaa Mnebhi
2021-08-16 11:59 ` [PATCH v1 4/6] gpio: mlxbf2: Use DEFINE_RES_MEM_NAMED() helper macro Andy Shevchenko
2021-08-16 13:07 ` Asmaa Mnebhi
2021-08-16 11:59 ` [PATCH v1 5/6] TODO: gpio: mlxbf2: Introduce IRQ support Andy Shevchenko
2021-08-16 21:34 ` Asmaa Mnebhi
2021-08-18 14:07 ` Andy Shevchenko
2021-08-18 22:40 ` Andrew Lunn
2021-08-19 12:28 ` Asmaa Mnebhi
2021-09-15 19:27 ` Asmaa Mnebhi
2021-09-15 20:19 ` Andrew Lunn
2021-08-16 11:59 ` [PATCH v1 6/6] TODO: net: mellanox: mlxbf_gige: Replace non-standard interrupt handling Andy Shevchenko
2021-08-16 23:06 ` Linus Walleij
2021-08-17 9:05 ` Andy Shevchenko [this message]
2021-08-16 12:06 ` [PATCH v1 0/6] gpio: mlxbf2: Introduce proper " Andy Shevchenko
2021-08-16 19:22 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRt7yqoukWSYmHMg@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=asmaa@nvidia.com \
--cc=bgolaszewski@baylibre.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=kuba@kernel.org \
--cc=limings@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).