From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C843C4320A for ; Tue, 17 Aug 2021 16:46:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2311C60F5E for ; Tue, 17 Aug 2021 16:46:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230270AbhHQQqu (ORCPT ); Tue, 17 Aug 2021 12:46:50 -0400 Received: from mga01.intel.com ([192.55.52.88]:23539 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbhHQQqs (ORCPT ); Tue, 17 Aug 2021 12:46:48 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10079"; a="238231523" X-IronPort-AV: E=Sophos;i="5.84,329,1620716400"; d="scan'208";a="238231523" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 09:46:15 -0700 X-IronPort-AV: E=Sophos;i="5.84,329,1620716400"; d="scan'208";a="593440452" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 09:46:13 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1mG2E3-00AoH4-Pt; Tue, 17 Aug 2021 19:46:07 +0300 Date: Tue, 17 Aug 2021 19:46:07 +0300 From: Andy Shevchenko To: Jakub Kicinski Cc: Jonathan Lemon , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Cochran Subject: Re: [PATCH v2 net-next 1/1] ptp_ocp: use bits.h macros for all masks Message-ID: References: <20210817122454.50616-1-andriy.shevchenko@linux.intel.com> <20210817064814.13c57002@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210817064814.13c57002@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 17, 2021 at 06:48:14AM -0700, Jakub Kicinski wrote: > On Tue, 17 Aug 2021 15:24:54 +0300 Andy Shevchenko wrote: > > Currently we are using BIT(), but GENMASK(). Make use of the latter one > > as well (far less error-prone, far more concise). > GENMASK is unsigned long: Ouch, thanks! -- With Best Regards, Andy Shevchenko