From: Rob Herring <robh@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: Peter Geis <pgwipeout@gmail.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/8] dt-bindings: phy: phy-rockchip-inno-usb2: add rk3568 documentation
Date: Tue, 17 Aug 2021 16:43:59 -0500 [thread overview]
Message-ID: <YRwtnxucxIeq+ayx@robh.at.kernel.org> (raw)
In-Reply-To: <c7ff9234-cc3b-3679-bc63-73c5eb825269@gmail.com>
On Tue, Aug 17, 2021 at 06:52:15PM +0200, Johan Jonker wrote:
> Hi Peter,
>
> Some comments. Have a look if it's useful.
>
> On 8/12/21 10:41 PM, Peter Geis wrote:
> > The rk3568 usb2phy node is a standalone node with a single muxed
> > interrupt.
> > Add documentation for it to phy-rockchip-inno-usb2.
> >
> > Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> > ---
> > .../bindings/phy/phy-rockchip-inno-usb2.yaml | 31 ++++++++++++++++---
> > 1 file changed, 27 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml
> > index 5bebd86bf8b6..d2a749c3f9a3 100644
> > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml
> > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml
> > @@ -18,6 +18,7 @@ properties:
> > - rockchip,rk3328-usb2phy
> > - rockchip,rk3366-usb2phy
> > - rockchip,rk3399-usb2phy
> > + - rockchip,rk3568-usb2phy
> > - rockchip,rv1108-usb2phy
> >
> > reg:
> > @@ -50,6 +51,9 @@ properties:
> > description:
> > Phandle to the extcon device providing the cable state for the otg phy.
> >
>
> > + interrupts:
> > + description: Muxed interrupt for both ports
> > +
>
> This allows every Rockchip SoC dtsi to add an interrupt here.
> You have only restricted the requirements.
> The goal is to restrict things and filter bogus properties.
> If it was done because it doesn't compile, maybe could you try/test/use
> something like the rockchip-io-domain.yaml $defs format.
Don't use $defs unless there's more than 1 copy needed of something. If
it happens to bypass some checks, it's only a matter of time til I fix
that.
This may be better solved with another schema file rather than a long
if/then schema. It's a judgement call.
>
> ===
>
> unevaluatedProperties: false
>
> allOf:
> - $ref: "#/$defs/rk3568"
>
> $defs:
> rk3568:
> if:
> properties:
> compatible:
> contains:
> const: rockchip,rk3568-usb2phy
>
> then:
> properties:
> interrupts:
> maxItems: 1
>
> required:
> - interrupts
>
> else:
> properties:
> host-port:
> properties:
> interrupts:
> description: host linestate interrupt
>
> interrupt-names:
> const: linestate
>
> required:
> - interrupts
> - interrupt-names
>
> otg-port:
> properties:
>
> interrupts:
> minItems: 1
> maxItems: 3
>
> interrupt-names:
> oneOf:
> - const: linestate
> - const: otg-mux
> - items:
> - const: otg-bvalid
> - const: otg-id
> - const: linestate
>
> required:
> - interrupts
> - interrupt-names
>
> > rockchip,usbgrf:
> > $ref: /schemas/types.yaml#/definitions/phandle
> > description:
> > @@ -78,8 +82,6 @@ properties:
> >
> > required:
> > - "#phy-cells"
>
> > - - interrupts
> > - - interrupt-names
>
> Also remove them as properties in this part when a separate $defs is used.
>
> >
> > otg-port:
> > type: object
> > @@ -109,8 +111,6 @@ properties:
> >
> > required:
> > - "#phy-cells"
>
> > - - interrupts
> > - - interrupt-names
>
> dito
>
> >
> > required:
> > - compatible
> > @@ -120,6 +120,29 @@ required:
> > - host-port
> > - otg-port
> >
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: rockchip,rk3568-usb2phy
>
> > + then:
>
> Test "if then else" alignment with yamllint
yamllint is not going to help there. What's needed is a meta-schema that
adds the dependencies.
>
> > + properties:
> > + interrupts:
> > + maxItems: 1
> > + required:
> > + - interrupts
>
> > + else:
>
> alignment
>
> > + properties:
> > + host-port:
> > + required:
> > + - interrupts
> > + - interrupt-names
> > + otg-port:
> > + required:
> > + - interrupts
> > + - interrupt-names
> > +
>
> > additionalProperties: false
>
> additionalProperties does workn't with allOf: - $ref. Use
> unevaluatedProperties.
>
> >
> > examples:
> >
>
next prev parent reply other threads:[~2021-08-17 21:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 20:41 [PATCH v2 0/8] phy-rockchip-inno-usb2: support rk356x usb2phy Peter Geis
2021-08-12 20:41 ` [PATCH v2 1/8] dt-bindings: soc: rockchip: add rk3568-usb2phy-grf Peter Geis
2021-08-17 21:31 ` Rob Herring
2021-08-12 20:41 ` [PATCH v2 2/8] dt-bindings: phy: phy-rockchip-inno-usb2: add rk3568 documentation Peter Geis
2021-08-17 16:52 ` Johan Jonker
2021-08-17 21:43 ` Rob Herring [this message]
2021-08-12 20:41 ` [PATCH v2 3/8] phy: phy-rockchip-inno-usb2: support #address_cells = 2 Peter Geis
2021-08-12 20:41 ` [PATCH v2 4/8] phy: phy-rockchip-inno-usb2: support standalone phy nodes Peter Geis
2021-08-12 20:41 ` [PATCH v2 5/8] phy: phy-rockchip-inno-usb2: support muxed interrupts Peter Geis
2021-08-12 20:41 ` [PATCH v2 6/8] phy: phy-rockchip-inno-usb2: add rk3568 support Peter Geis
2021-08-12 20:41 ` [PATCH v2 7/8] arm64: dts: rockchip: add usb2 nodes to rk3568 device tree Peter Geis
2021-10-14 10:02 ` Michael Riesch
2021-08-12 20:41 ` [PATCH v2 8/8] arm64: dts: rockchip: add Quartz64-A usb2 support Peter Geis
2021-10-14 10:11 ` [PATCH v2 0/8] phy-rockchip-inno-usb2: support rk356x usb2phy Michael Riesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRwtnxucxIeq+ayx@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).