From: Ido Schimmel <idosch@idosch.org>
To: 13145886936@163.com
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
gushengxian <gushengxian@yulong.com>
Subject: Re: [PATCH] flow_offload: action should not be NULL when it is referenced
Date: Wed, 18 Aug 2021 14:58:19 +0300 [thread overview]
Message-ID: <YRz1297sFSjG7/Cc@shredder> (raw)
In-Reply-To: <20210626115606.1243151-1-13145886936@163.com>
On Sat, Jun 26, 2021 at 04:56:06AM -0700, 13145886936@163.com wrote:
> From: gushengxian <gushengxian@yulong.com>
>
> "action" should not be NULL when it is referenced.
>
> Signed-off-by: gushengxian <13145886936@163.com>
> Signed-off-by: gushengxian <gushengxian@yulong.com>
> ---
> include/net/flow_offload.h | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
> index dc5c1e69cd9f..69c9eabf8325 100644
> --- a/include/net/flow_offload.h
> +++ b/include/net/flow_offload.h
> @@ -319,12 +319,14 @@ flow_action_mixed_hw_stats_check(const struct flow_action *action,
> if (flow_offload_has_one_action(action))
> return true;
>
> - flow_action_for_each(i, action_entry, action) {
> - if (i && action_entry->hw_stats != last_hw_stats) {
> - NL_SET_ERR_MSG_MOD(extack, "Mixing HW stats types for actions is not supported");
> - return false;
> + if (action) {
This patch generates a smatch warning:
include/net/flow_offload.h:322 flow_action_mixed_hw_stats_check() warn: variable dereferenced before check 'action' (see line 319)
Why the patch is needed? 'action' is already dereferenced in
flow_offload_has_one_action()
> + flow_action_for_each(i, action_entry, action) {
> + if (i && action_entry->hw_stats != last_hw_stats) {
> + NL_SET_ERR_MSG_MOD(extack, "Mixing HW stats types for actions is not supported");
> + return false;
> + }
> + last_hw_stats = action_entry->hw_stats;
> }
> - last_hw_stats = action_entry->hw_stats;
> }
> return true;
> }
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2021-08-18 11:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-26 11:56 [PATCH] flow_offload: action should not be NULL when it is referenced 13145886936
2021-06-28 21:30 ` patchwork-bot+netdevbpf
2021-08-18 11:58 ` Ido Schimmel [this message]
2021-08-18 12:36 ` Jamal Hadi Salim
2021-08-18 13:39 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRz1297sFSjG7/Cc@shredder \
--to=idosch@idosch.org \
--cc=13145886936@163.com \
--cc=davem@davemloft.net \
--cc=gushengxian@yulong.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).