From: Luis Chamberlain <mcgrof@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com,
kbusch@kernel.org, sagi@grimberg.me, adrian.hunter@intel.com,
beanhuo@micron.com, ulf.hansson@linaro.org, avri.altman@wdc.com,
swboyd@chromium.org, agk@redhat.com, snitzer@redhat.com,
josef@toxicpanda.com, hare@suse.de, bvanassche@acm.org,
ming.lei@redhat.com, linux-scsi@vger.kernel.org,
linux-nvme@lists.infradead.org, linux-mmc@vger.kernel.org,
dm-devel@redhat.com, nbd@other.debian.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/10] dm: add add_disk() error handling
Date: Mon, 30 Aug 2021 14:00:58 -0700 [thread overview]
Message-ID: <YS1HCgP/XdWmMtFN@bombadil.infradead.org> (raw)
In-Reply-To: <YSnnXdKLvxEY8yay@infradead.org>
On Sat, Aug 28, 2021 at 08:35:57AM +0100, Christoph Hellwig wrote:
> On Fri, Aug 27, 2021 at 11:55:14AM -0700, Luis Chamberlain wrote:
> > > I think the add_disk should just return r. If you look at the
> > > callers they eventualy end up in dm_table_destroy, which does
> > > this cleanup.
> >
> > I don't see it. What part of dm_table_destroy() does this?
>
> Sorry, dm_destroy, not dm_table_destroy. For dm_early_create it's
> trivial as that calls both dm_table_destroy and dm_destroy in the error
> path. The normal table_load case is a separate ioctl, but if that
> fails userspace needs to call the DM_DEV_REMOVE_CMD to cleanup
> the state - similar to any other failure.
I see, ok sure I'll document this on the commit log as its not so
obvious.
Luis
next prev parent reply other threads:[~2021-08-30 21:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 20:29 [PATCH 00/10] block: first batch of add_disk() error handling conversions Luis Chamberlain
2021-08-23 20:29 ` [PATCH 01/10] scsi/sd: use blk_cleanup_queue() insted of put_disk() Luis Chamberlain
2021-08-24 5:52 ` Christoph Hellwig
2021-08-27 18:27 ` Luis Chamberlain
2021-08-28 7:26 ` Christoph Hellwig
2021-08-23 20:29 ` [PATCH 02/10] scsi/sd: add error handling support for add_disk() Luis Chamberlain
2021-08-24 5:58 ` Christoph Hellwig
2021-08-23 20:29 ` [PATCH 03/10] scsi/sr: use blk_cleanup_disk() instead of put_disk() Luis Chamberlain
2021-08-24 6:00 ` Christoph Hellwig
2021-08-27 18:28 ` Luis Chamberlain
2021-08-23 20:29 ` [PATCH 04/10] scsi/sr: add error handling support for add_disk() Luis Chamberlain
2021-08-24 6:04 ` Christoph Hellwig
2021-08-23 20:29 ` [PATCH 05/10] nvme: " Luis Chamberlain
2021-08-24 6:09 ` Christoph Hellwig
2021-08-27 18:32 ` Luis Chamberlain
2021-08-23 20:29 ` [PATCH 06/10] mmc/core/block: " Luis Chamberlain
2021-08-24 6:13 ` Christoph Hellwig
2021-08-27 18:42 ` Luis Chamberlain
2021-08-28 7:32 ` Christoph Hellwig
2021-08-30 20:42 ` Luis Chamberlain
2021-08-23 20:29 ` [PATCH 07/10] md: " Luis Chamberlain
2021-08-24 6:15 ` Christoph Hellwig
2021-08-23 20:29 ` [PATCH 08/10] dm: add add_disk() error handling Luis Chamberlain
2021-08-24 6:21 ` Christoph Hellwig
2021-08-27 18:55 ` Luis Chamberlain
2021-08-28 7:35 ` Christoph Hellwig
2021-08-30 21:00 ` Luis Chamberlain [this message]
2021-08-23 20:29 ` [PATCH 09/10] loop: add error handling support for add_disk() Luis Chamberlain
2021-08-24 6:25 ` Christoph Hellwig
2021-08-23 20:29 ` [PATCH 10/10] nbd: " Luis Chamberlain
2021-08-24 6:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YS1HCgP/XdWmMtFN@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=agk@redhat.com \
--cc=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jejb@linux.ibm.com \
--cc=josef@toxicpanda.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=nbd@other.debian.org \
--cc=sagi@grimberg.me \
--cc=snitzer@redhat.com \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).