From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DFEFC43214 for ; Tue, 31 Aug 2021 13:17:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FEC161041 for ; Tue, 31 Aug 2021 13:17:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235218AbhHaNSD (ORCPT ); Tue, 31 Aug 2021 09:18:03 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50210 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230175AbhHaNSC (ORCPT ); Tue, 31 Aug 2021 09:18:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=O0tbD+MhxYcxlWeFJDcgfYosGr5RiD+IdZLr5hwd1OI=; b=cVzPwALFENJsChIX2055ZXy1JL qt4lmrRBX8oXBiWXmBjYXg7ompSsfXwCclG/zP8Jcftu96My4+xefEuCxy+bpNoIfLKBCcClC9KEE 2cXda4H4jA/Mxx+Ec6LONitWbtADK7mBLX0J99LaWXTT0KfqIiTB7sUIXRbayR4NLQKE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mL3dD-004ilj-3l; Tue, 31 Aug 2021 15:16:51 +0200 Date: Tue, 31 Aug 2021 15:16:51 +0200 From: Andrew Lunn To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Linus Walleij , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Len Brown , Alvin Sipraga , kernel-team@android.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v1 1/2] driver core: fw_devlink: Add support for FWNODE_FLAG_BROKEN_PARENT Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > I must admit, my main problem at the moment is -rc1 in two weeks > > time. It seems like a number of board with Ethernet switches will be > > broken, that worked before. phy-handle is not limited to switch > > drivers, it is also used for Ethernet drivers. So it could be, a > > number of Ethernet drivers are also going to be broken in -rc1? > > Again, in those cases, based on your FEC example, fw_devlink=on > actually improves things. Debatable. I did some testing. As expected some boards with Ethernet switches are now broken. Without fw_devlink=on, some boards are not optimal, but they actually work. With it, they are broken. I did a bisect, and they have been broken since: ea718c699055c8566eb64432388a04974c43b2ea is the first bad commit commit ea718c699055c8566eb64432388a04974c43b2ea Author: Saravana Kannan Date: Tue Mar 2 13:11:32 2021 -0800 Revert "Revert "driver core: Set fw_devlink=on by default"" This reverts commit 3e4c982f1ce75faf5314477b8da296d2d00919df. Since all reported issues due to fw_devlink=on should be addressed by this series, revert the revert. fw_devlink=on Take II. Signed-off-by: Saravana Kannan Link: https://lore.kernel.org/r/20210302211133.2244281-4-saravanak@google.com Signed-off-by: Greg Kroah-Hartman drivers/base/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) So however it is fixed, it needs to go into stable, not just -rc1. > Again, it's not a widespread problem as I explained before. > fw_devlink=on has been the default for 2 kernel versions now. With no > unfixed reported issues. Given that some Ethernet switches have been broken all that time, i wonder what else has been broken? Normally, the kernel which is release in December becomes the next LTS. It then gets picked up by the distros and more wide spread tested. So it could be, you get a flood of reports in January and February about things which are broken. This is why i don't think you should be relying on bug reports, you should be taking a more proactive stance and trying to analyse the DTB blobs. I will spend some time trying out your proposed fix. See if they are a quick fix for stable. Andrew