From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 036F8C4320A for ; Mon, 23 Aug 2021 07:32:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB45261078 for ; Mon, 23 Aug 2021 07:32:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235151AbhHWHdi (ORCPT ); Mon, 23 Aug 2021 03:33:38 -0400 Received: from mga05.intel.com ([192.55.52.43]:59466 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234861AbhHWHdh (ORCPT ); Mon, 23 Aug 2021 03:33:37 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10084"; a="302637138" X-IronPort-AV: E=Sophos;i="5.84,343,1620716400"; d="scan'208";a="302637138" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2021 00:32:55 -0700 X-IronPort-AV: E=Sophos;i="5.84,343,1620716400"; d="scan'208";a="574563672" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2021 00:32:48 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1mI4Rl-00ChFf-Pn; Mon, 23 Aug 2021 10:32:41 +0300 Date: Mon, 23 Aug 2021 10:32:41 +0300 From: Andy Shevchenko To: Hans de Goede Cc: Kate Hsuan , Srinivas Pandruvada , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com, Mark Gross , Alex Hung , Rajneesh Bhardwaj , David E Box , Zha Qipeng , "David E. Box" , AceLan Kao , Jithu Joseph , Maurice Ma Subject: Re: [PATCH v5 07/20] platform/x86: pmc_atom: Move to intel sub-directory Message-ID: References: <20210820110458.73018-1-andriy.shevchenko@linux.intel.com> <20210820110458.73018-8-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 20, 2021 at 08:18:17PM +0200, Hans de Goede wrote: > On 8/20/21 1:04 PM, Andy Shevchenko wrote: > > Move Intel Atom PMC driver to intel sub-directory to improve readability. > > > > Signed-off-by: Andy Shevchenko > > This means that pmc_atom will now not be build if X86_PLATFORM_DRIVERS_INTEL > is not set (and PCI is enabled). Which will cause missing pmc_atom_read/_write > symbols in drivers/acpi/acpi_lpss.c. So I have dropped this patch from the > set, while applying the rest. > > Note I'm thinking that we should just remove the whole X86_PLATFORM_DRIVERS_INTEL > Kconfig option and in the drivers/platform/x86/Makefile replace: > > obj-$(CONFIG_X86_PLATFORM_DRIVERS_INTEL) += intel/ > > with: > > obj-y += intel/ > > This will also allows us to fix the scu issue without needing any > changes to drivers/mfd/Kconfig . > > But this can all wait for the 2nd round of renames after 5.15-rc1. > > For now I'm moving forward with this v5 series, except with this > patch dropped. Indeed. Thanks for the analysis. Btw, should we convert Dell subdir to something similar in terms of Kconfig? -- With Best Regards, Andy Shevchenko