From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16FADC4320A for ; Mon, 23 Aug 2021 10:01:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E96C561246 for ; Mon, 23 Aug 2021 10:01:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235986AbhHWKCa (ORCPT ); Mon, 23 Aug 2021 06:02:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233281AbhHWKC3 (ORCPT ); Mon, 23 Aug 2021 06:02:29 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE7EEC061757 for ; Mon, 23 Aug 2021 03:01:46 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id h1so5755883pjs.2 for ; Mon, 23 Aug 2021 03:01:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=a83R/B9Lm/qgVoAlx8qnij+Ld74e3iDN4AlBrXWn3Xk=; b=YZAtljkGqZOJTdpRv6gq3v0m2WWXbAf3uPSSoPDrKNT7qchBAg69QpaFsao25+MF+w HtHHW7Xa3yHKhgbPyYjKcjpcuIY67qgVoPIzkF+0JqcXxgMhml9BkAsrUVsEi3Hvr/Yw ghdLNA3EoSYqVEhybvndDhd3KlSRoZ9Ctz7bZQJa4arwFKkUbcwzvwto9nAuG4oNm9sb U8Ln9GL1z6ZUsb3QdhRRTO5kqRTyf9FVQg/n+4XuaLKkZYzDbGN50oWhWdoDDT+5QYXG K2qKN2aKdOwgp6ik/5WSHkHQsbvQSBjSfbAXPs4dbrsrD2J+gdq+fzTXW9ESrBIurWGT Uu3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a83R/B9Lm/qgVoAlx8qnij+Ld74e3iDN4AlBrXWn3Xk=; b=MW59ztXe6iM0gxl/NFyQRsJbfizxL4ogWRiOXcJuNYP4Xs8djgjfpQfTHm4n55qZXA tQaw2r6CKfkEoikBARUQLMCZ4iUUAsppNKQvVNj2RM8LSW+3rQYyxllVQM5xvYVqYXeo 9LcpUwxd47POM9L38u8ao/A0wB/aZserNV6wwuDO/j4o9HkqXONAGT8VVJlCbA+QBlEF Uw7tjlEMGdMK5iuFrKDxQ0I8Y6q+ZRG5s9D9v7G4/KBuOfnW/D9NWbA2+uKl9zBzAFH2 i/QzmNDycxnBwlV8wtxpkdwHcbIvLdQJBrFfE8qUkKSvWHGqfesrIp3nB7SKrBGsmW2k vM9Q== X-Gm-Message-State: AOAM531xcS7YxcasqdEYipBRVwF5JtuejNmJc7lRBqESeJozfk3u+DTK yHzdafVoHoS+TItrQzUin/uQCw== X-Google-Smtp-Source: ABdhPJz+hz17o/gcGS8iJUfbpeh537f4BVJ+xiYeyWgkJMD344jXhdt++YyEDBEi6/n1J0b8QZSPZQ== X-Received: by 2002:a17:90a:4584:: with SMTP id v4mr19165244pjg.169.1629712906127; Mon, 23 Aug 2021 03:01:46 -0700 (PDT) Received: from google.com ([2401:fa00:1:10:bc5a:af6a:3f08:a084]) by smtp.gmail.com with ESMTPSA id g13sm15458871pfo.53.2021.08.23.03.01.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 03:01:45 -0700 (PDT) Date: Mon, 23 Aug 2021 18:01:40 +0800 From: Tzung-Bi Shih To: Irui Wang Cc: Hans Verkuil , Tzung-Bi Shih , Alexandre Courbot , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Yong Wu , Hsin-Yi Wang , Maoguang Meng , Longfei Wang , Yunfei Dong , Fritz Koenig , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH 2/9] media: mtk-vcodec: Use component framework to manage encoder hardware Message-ID: References: <20210816105934.28265-1-irui.wang@mediatek.com> <20210816105934.28265-3-irui.wang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210816105934.28265-3-irui.wang@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 16, 2021 at 06:59:27PM +0800, Irui Wang wrote: > +static struct component_match *mtk_venc_match_add(struct mtk_vcodec_dev *dev) > +{ > + struct platform_device *pdev = dev->plat_dev; > + struct component_match *match = NULL; > + int i; > + > + for (i = 0; i < ARRAY_SIZE(mtk_venc_comp_ids); i++) { > + enum mtk_venc_hw_id comp_idx; > + struct device_node *comp_node; > + const struct of_device_id *of_id; To be neat, prefer to define the variables outside of the loop (i.e. at the beginning of the function). > + > + comp_node = of_find_compatible_node(NULL, NULL, > + mtk_venc_comp_ids[i].compatible); > + if (!comp_node) > + continue; > + > + of_id = of_match_node(mtk_venc_comp_ids, comp_node); > + if (!of_id) { > + dev_err(&pdev->dev, "Failed to get match node\n"); Need to call of_node_put() actually, but see comment below. > + return ERR_PTR(-EINVAL); > + } > + > + comp_idx = (enum mtk_venc_hw_id)of_id->data; For getting the comp_idx, mtk_venc_comp_ids[i].data should be sufficient. If so, of_match_node() can be removed so that the error handling path won't need to call of_node_put(). > @@ -239,6 +314,7 @@ static int mtk_vcodec_probe(struct platform_device *pdev) > phandle rproc_phandle; > enum mtk_vcodec_fw_type fw_type; > int ret; > + struct component_match *match = NULL; It doesn't need to be initialized. > - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > - if (res == NULL) { > - dev_err(&pdev->dev, "failed to get irq resource"); > - ret = -ENOENT; > - goto err_res; > - } > + res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > + if (!res) { > + dev_err(&pdev->dev, "failed to get irq resource"); > + ret = -ENOENT; > + goto err_res; > + } res is not used. Can be removed in next version or in another patch. > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_hw.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_hw.c > new file mode 100644 > index 000000000000..4e6a8a81ff67 > --- /dev/null > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_hw.c > @@ -0,0 +1,179 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2021 MediaTek Inc. > + */ > + > +#include > +#include > +#include > +#include > +#include Would be better to maintain an order. > +#include "mtk_vcodec_enc_hw.h" > +#include "mtk_vcodec_enc.h" Would be better to maintain an order. > +static irqreturn_t mtk_enc_comp_irq_handler(int irq, void *priv) > +{ > + struct mtk_venc_comp_dev *dev = priv; > + struct mtk_vcodec_ctx *ctx; > + unsigned long flags; > + void __iomem *addr; > + > + spin_lock_irqsave(&dev->master_dev->irqlock, flags); > + ctx = dev->curr_ctx; > + spin_unlock_irqrestore(&dev->master_dev->irqlock, flags); > + if (!ctx) > + return IRQ_HANDLED; Here is a read lock for the curr_ctx. The patch doesn't contain the write lock part. I am not sure if the following situation would be happened: 1. curr_ctx is not NULL. 2. mtk_enc_comp_irq_handler() gets the curr_ctx. 3. The curr_ctx has been destroyed somewhere. 4. mtk_enc_comp_irq_handler() finds the ctx is not NULL so that it continues to execute. 5. Something wrong in latter mtk_enc_comp_irq_handler() because the ctx has been destroyed. Does it make more sense to set curr_ctx to NULL to indicate the ownership has been transferred to mtk_enc_comp_irq_handler()? For example: spin_lock_irqsave(...); ctx = dev->curr_ctx; dev->curr_ctx = NULL; spin_unlock_irqrestore(...); > +static int mtk_venc_comp_bind(struct device *dev, > + struct device *master, void *data) > +{ > + struct mtk_venc_comp_dev *comp_dev = dev_get_drvdata(dev); > + struct mtk_vcodec_dev *master_dev = data; > + int i; > + > + for (i = 0; i < MTK_VENC_HW_MAX; i++) { > + if (dev->of_node != master_dev->enc_comp_node[i]) > + continue; > + > + /*add component device by order*/ > + if (comp_dev->core_id == MTK_VENC_CORE0) > + master_dev->enc_comp_dev[MTK_VENC_CORE0] = comp_dev; > + else if (comp_dev->core_id == MTK_VENC_CORE1) > + master_dev->enc_comp_dev[MTK_VENC_CORE1] = comp_dev; > + else > + return -EINVAL; if (comp_dev->core_id < 0 || comp_dev->core_id >= MTK_VENC_HW_MAX) return -EINVAL; master_dev->enc_comp_dev[comp_dev->core_id] = comp_dev;