From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E49AC4320E for ; Mon, 23 Aug 2021 15:27:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25AE9613AB for ; Mon, 23 Aug 2021 15:27:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231589AbhHWP1s (ORCPT ); Mon, 23 Aug 2021 11:27:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231574AbhHWP1n (ORCPT ); Mon, 23 Aug 2021 11:27:43 -0400 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47E09C061757 for ; Mon, 23 Aug 2021 08:26:59 -0700 (PDT) Received: by mail-ot1-x32a.google.com with SMTP id a20-20020a0568300b9400b0051b8ca82dfcso16377625otv.3 for ; Mon, 23 Aug 2021 08:26:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ydN0lJMPBQznWvVfcNZ1noFygSEX/rDVntQ7OSZxUnE=; b=R6VuIOSvA6Xca63sq1sLs5bqzEphhl9ON+NL8V5mEbAA3hu5kqd2bSLV1b0WlayJm+ KGEZLXsQzLzJNn7n3AMZMpjjCJuHA45mIYBDVWvWt4HRt5pNuXeUIg9YfyQEV3N9XdAH vujVT1LbUXocDgJ0cw+heOhLL6bJCGVud2nI0LrykKD1d78UpY/CsUqpOYOypE5mFOHR Eb2z26M6mcXbjWkL1lbXHs6TconVBGnPPIEUSexzRBaBn0VMSasCrUWWErS2qQH0dNJi ZKEWdIrXQhsyrlo79NrSQ63FMl9uZvCZQyOAdfA+lWsW+yvhy+mjfsd6U0MZe23oM/GK //Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ydN0lJMPBQznWvVfcNZ1noFygSEX/rDVntQ7OSZxUnE=; b=otiHEH9CA4SobuscsoaLWqlTMvo4pZUvZphvGXQgbSuUaD33qv3veCPuAxHOE7m/3P EzjtQ0K0MqfaR71TM74QQVUyDIcTKaWAWnunY7k+fyEKFYn/cyoQJzRApH7VCz7jug6k znTwLm/iMEHWz4cmG4wA8wENmZwKCXR3BxGRi9N7deVnNYCzL5yLiieQAWP/hoK3BiI6 h5B0o//DfJskikytSFL2Jqq1rp3nSm9zk5vYZaUCRVzOlCfew/2GgDqQ3v9Cskc8AEUf kUml/59fm0MVCnKg1roP3WQdPo34I9BhB2Ry2wVmxTwvUmQHPndN2+aQdVrutRfDhVTV 5PJQ== X-Gm-Message-State: AOAM532uqv6AP2sZJtWhoXB91CfwGiSOHqtmZLQmJbDVkOo4npjNTJL3 Be8B4y+sV6mhcTA/yY490jLl3w== X-Google-Smtp-Source: ABdhPJzw59rtahoBqiQZenemcDF6BgL7l1OthPHspWZBn84xBiGEbfLWhV0qr+wPWPc9Y8cReWOC3Q== X-Received: by 2002:a9d:5d01:: with SMTP id b1mr10133457oti.263.1629732418617; Mon, 23 Aug 2021 08:26:58 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id p2sm3732086oip.35.2021.08.23.08.26.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 08:26:58 -0700 (PDT) Date: Mon, 23 Aug 2021 08:28:17 -0700 From: Bjorn Andersson To: Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Andy Gross , Linus Walleij , Rob Herring , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: Add SM6350 pinctrl bindings Message-ID: References: <20210820203751.232645-1-konrad.dybcio@somainline.org> <20210820203751.232645-2-konrad.dybcio@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210820203751.232645-2-konrad.dybcio@somainline.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 20 Aug 13:37 PDT 2021, Konrad Dybcio wrote: > Add device tree binding Documentation details for Qualcomm SM6350 > pinctrl driver. > > Signed-off-by: Konrad Dybcio > --- > .../bindings/pinctrl/qcom,sm6350-pinctrl.yaml | 156 ++++++++++++++++++ > .../bindings/pinctrl/qcom,tlmm-common.yaml | 2 +- > 2 files changed, 157 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml > new file mode 100644 > index 000000000000..e4d8b7a044e6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6350-pinctrl.yaml > @@ -0,0 +1,156 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/qcom,sm6350-pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies, Inc. SM6350 TLMM block > + > +maintainers: > + - Konrad Dybcio > + > +description: | > + This binding describes the Top Level Mode Multiplexer (TLMM) block found > + in the SM6350 platform. > + > +allOf: > + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml# > + > +properties: > + compatible: > + const: qcom,sm6350-tlmm > + > + reg: > + maxItems: 1 > + > + interrupts: true > + interrupt-controller: true > + '#interrupt-cells': true > + gpio-controller: true > + gpio-reserved-ranges: true > + '#gpio-cells': true > + gpio-ranges: true > + wakeup-parent: true > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +patternProperties: > + '-state$': > + oneOf: > + - $ref: "#/$defs/qcom-sm6350-tlmm-state" > + - patternProperties: > + ".*": > + $ref: "#/$defs/qcom-sm6350-tlmm-state" > + > +$defs: > + qcom-sm6350-tlmm-state: > + type: object > + description: > + Pinctrl node's client devices use subnodes for desired pin configuration. > + Client device subnodes use below standard properties. > + $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" > + > + properties: > + pins: > + description: > + List of gpio pins affected by the properties specified in this > + subnode. > + items: > + oneOf: > + - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-9][0-9]|20[0-3])$" "^gpio([0-9]|[1-9][0-9]|1[0-4][0-9]|15[0-7])$" > + - enum: [ sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd, sdc2_data ] > + minItems: 1 > + maxItems: 36 > + > + function: > + description: > + Specify the alternative function to be configured for the specified > + pins. > + > + enum: [ adsp_ext, agera_pll, atest_char, atest_char0, atest_char1, atest_char2, > + atest_char3, atest_tsens, atest_tsens2, atest_usb1, atest_usb10, atest_usb11, > + atest_usb12, atest_usb13, atest_usb2, atest_usb20, atest_usb21, atest_usb22, > + atest_usb23, audio_ref, btfm_slimbus, cam_mclk0, cam_mclk1, cam_mclk2, cam_mclk3, > + cam_mclk4, cci_async, cci_i2c, cci_timer0, cci_timer1, cci_timer2, cci_timer3, > + cci_timer4, cri_trng, dbg_out, ddr_bist, ddr_pxi0, ddr_pxi1, ddr_pxi2, ddr_pxi3, > + dp_hot, edp_lcd, gcc_gp1, gcc_gp2, gcc_gp3, gp_pdm0, gp_pdm1, gp_pdm2, gpio, > + gps_tx, ibi_i3c, jitter_bist, ldo_en, ldo_update, lpass_ext, m_voc, mclk, > + mdp_vsync, mdp_vsync0, mdp_vsync1, mdp_vsync2, mdp_vsync3, mi2s_0, mi2s_1, mi2s_2, > + mss_lte, nav_gpio, nav_pps, pa_indicator, pcie0_clk, phase_flag0, phase_flag1, > + phase_flag10, phase_flag11, phase_flag12, phase_flag13, phase_flag14, phase_flag15, > + phase_flag16, phase_flag17, phase_flag18, phase_flag19, phase_flag2, phase_flag20, > + phase_flag21, phase_flag22, phase_flag23, phase_flag24, phase_flag25, phase_flag26, > + phase_flag27, phase_flag28, phase_flag29, phase_flag3, phase_flag30, phase_flag31, > + phase_flag4, phase_flag5, phase_flag6, phase_flag7, phase_flag8, phase_flag9, > + pll_bist, pll_bypassnl, pll_reset, prng_rosc, qdss_cti, qdss_gpio, qdss_gpio0, > + qdss_gpio1, qdss_gpio10, qdss_gpio11, qdss_gpio12, qdss_gpio13, qdss_gpio14, > + qdss_gpio15, qdss_gpio2, qdss_gpio3, qdss_gpio4, qdss_gpio5, qdss_gpio6, > + qdss_gpio7, qdss_gpio8, qdss_gpio9, qlink0_enable, qlink0_request, qlink0_wmss, > + qlink1_enable, qlink1_request, qlink1_wmss, qup00, qup01, qup02, qup10, qup11, > + qup12, qup13_f1, qup13_f2, qup14, rffe0_clk, rffe0_data, rffe1_clk, rffe1_data, > + rffe2_clk, rffe2_data, rffe3_clk, rffe3_data, rffe4_clk, rffe4_data, sd_write, > + sdc1_tb, sdc2_tb, sp_cmu, tgu_ch0, tgu_ch1, tgu_ch2, tgu_ch3, tsense_pwm1, > + tsense_pwm2, uim1_clk, uim1_data, uim1_present, uim1_reset, uim2_clk, uim2_data, > + uim2_present, uim2_reset, usb_phy, vfr_1, vsense_trigger, wlan1_adc0, wlan1_adc1, > + wlan2_adc0, wlan2_adc1, ] > + > + > + bias-disable: true > + bias-pull-down: true > + bias-pull-up: true > + drive-strength: true > + input-enable: true > + output-high: true > + output-low: true > + > + required: > + - pins > + - function > + > + additionalProperties: false > + > +examples: > + - | > + #include > + pinctrl@f100000 { > + compatible = "qcom,sm6350-tlmm"; > + reg = <0x0f100000 0x300000>; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + ; > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + gpio-ranges = <&tlmm 0 0 156>; Shouldn't this be 157? > + > + gpio-wo-subnode-state { > + pins = "gpio1"; > + function = "gpio"; > + }; > + > + uart-w-subnodes-state { > + rx { > + pins = "gpio25"; > + function = "qup13_f2"; > + bias-disable; > + }; > + > + tx { > + pins = "gpio26"; > + function = "qup13_f2"; > + bias-disable; > + }; > + }; > + }; > +... > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml > index 3b37cf102d41..99975122a2ce 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml > @@ -17,7 +17,7 @@ properties: > interrupts: > description: > Specifies the TLMM summary IRQ > - maxItems: 1 > + maxItems: 9 Is this to support direct connected interrupts? Don't you need to add minItems: 1, to permit the other bindings to not define these? I think that's what Rob's automatic reply complains about at least. PS. Any plans to work up support for direct connected interrupts? I think that and "egpio" is the only downstream delta these days... That said, I don't know if anyone actually uses direct connected interrupts? Regards, Bjorn