From: Christoph Hellwig <hch@infradead.org>
To: Ritesh Harjani <riteshh@linux.ibm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Dennis Zhou <dennis@kernel.org>, Tejun Heo <tj@kernel.org>,
Christoph Lameter <cl@linux.com>
Subject: Re: [PATCH 1/2] kernel/workqueue: Make schedule_on_each_cpu as EXPORT_SYMBOL
Date: Mon, 23 Aug 2021 13:58:56 +0100 [thread overview]
Message-ID: <YSObkFQEPY3f1XKE@infradead.org> (raw)
In-Reply-To: <f824a9b589be576f5dac9109ca07d65d6b83219a.1629712557.git.riteshh@linux.ibm.com>
On Mon, Aug 23, 2021 at 03:37:45PM +0530, Ritesh Harjani wrote:
> Make schedule_on_each_cpu as EXPORT_SYMBOL.
>
> Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
> ---
> kernel/workqueue.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index f148eacda55a..6f15e4afbf38 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -3309,6 +3309,7 @@ int schedule_on_each_cpu(work_func_t func)
> free_percpu(works);
> return 0;
> }
> +EXPORT_SYMBOL(schedule_on_each_cpu);
Please don't export random bits just for a test. Especially non without
an EXPORT_SYMBOL_GPL.
prev parent reply other threads:[~2021-08-23 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 10:07 [PATCH 1/2] kernel/workqueue: Make schedule_on_each_cpu as EXPORT_SYMBOL Ritesh Harjani
2021-08-23 10:07 ` [PATCH 2/2] lib/percpu_test: Add extra tests in percpu_test Ritesh Harjani
2021-08-23 15:10 ` kernel test robot
2021-08-23 17:40 ` kernel test robot
2021-08-23 12:58 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSObkFQEPY3f1XKE@infradead.org \
--to=hch@infradead.org \
--cc=cl@linux.com \
--cc=dennis@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riteshh@linux.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).