From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD6DFC4338F for ; Mon, 23 Aug 2021 13:16:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0A066126A for ; Mon, 23 Aug 2021 13:16:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236646AbhHWNRh (ORCPT ); Mon, 23 Aug 2021 09:17:37 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:36734 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236163AbhHWNRf (ORCPT ); Mon, 23 Aug 2021 09:17:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=gN2erQa4xHFleHaPe8a5OvdToFtGAqPESdt/RHJIVNs=; b=zWC+lJqsd06WF7ILg+Thgu9mE1 ZtNqlLoOFhBmLLS/ePijatX5aumiOoXsqBcgdLd5kVN38TsPXrlRbHKvRlYUfpmI3bpAqjtOq04D+ b8i3wUaXqWbQ6f4RvaXSiHJvgkMgBLYR8C6AzHIucciniJaT5whL3C+oR+Y5KkAl5J6M=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mI9oi-003T7N-Rk; Mon, 23 Aug 2021 15:16:44 +0200 Date: Mon, 23 Aug 2021 15:16:44 +0200 From: Andrew Lunn To: Marek Szyprowski Cc: Saravana Kannan , Rob Herring , Frank Rowand , netdev@vger.kernel.org, kernel-team@android.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong , linux-amlogic@lists.infradead.org Subject: Re: [PATCH v2] of: property: fw_devlink: Add support for "phy-handle" property Message-ID: References: <20210818021717.3268255-1-saravanak@google.com> <0a2c4106-7f48-2bb5-048e-8c001a7c3fda@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a2c4106-7f48-2bb5-048e-8c001a7c3fda@samsung.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 23, 2021 at 02:08:48PM +0200, Marek Szyprowski wrote: > Hi, > > On 18.08.2021 04:17, Saravana Kannan wrote: > > Allows tracking dependencies between Ethernet PHYs and their consumers. > > > > Cc: Andrew Lunn > > Cc: netdev@vger.kernel.org > > Signed-off-by: Saravana Kannan > > This patch landed recently in linux-next as commit cf4b94c8530d ("of: > property: fw_devlink: Add support for "phy-handle" property"). It breaks > ethernet operation on my Amlogic-based ARM64 boards: Odroid C4 > (arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts) and N2 > (meson-g12b-odroid-n2.dts) as well as Khadas VIM3/VIM3l > (meson-g12b-a311d-khadas-vim3.dts and meson-sm1-khadas-vim3l.dts). > > In case of OdroidC4 I see the following entries in the > /sys/kernel/debug/devices_deferred: > > ff64c000.mdio-multiplexer > ff3f0000.ethernet > > Let me know if there is anything I can check to help debugging this issue. Hi Marek Please try this. Completetly untested, not even compile teseted: diff --git a/drivers/of/property.c b/drivers/of/property.c index 0c0dc2e369c0..7c4e257c0a81 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1292,6 +1292,7 @@ DEFINE_SIMPLE_PROP(resets, "resets", "#reset-cells") DEFINE_SIMPLE_PROP(leds, "leds", NULL) DEFINE_SIMPLE_PROP(backlight, "backlight", NULL) DEFINE_SIMPLE_PROP(phy_handle, "phy-handle", NULL) +DEFINE_SIMPLE_PROP(mdio_parent_bus, "mdio-parent-bus", NULL); DEFINE_SUFFIX_PROP(regulators, "-supply", NULL) DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells") @@ -1381,6 +1382,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { { .parse_prop = parse_leds, }, { .parse_prop = parse_backlight, }, { .parse_prop = parse_phy_handle, }, + { .parse_prop = parse_mdio_parent_bus, }, { .parse_prop = parse_gpio_compat, }, { .parse_prop = parse_interrupts, }, { .parse_prop = parse_regulators, }, Andrew