From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A714AC4320A for ; Tue, 24 Aug 2021 14:21:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 920AE6127B for ; Tue, 24 Aug 2021 14:21:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237767AbhHXOWR (ORCPT ); Tue, 24 Aug 2021 10:22:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237066AbhHXOWN (ORCPT ); Tue, 24 Aug 2021 10:22:13 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 570A5C061764; Tue, 24 Aug 2021 07:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8p5CUy6U95FpiQX1SR3TxR7Nlkajc1FQ/FDXrLP/IZA=; b=gmQStllbsDfxhL9Ny4Ypbajc9B AcuIKR5UEnqGNmPSkJNryXHo5K3/qGo9XisKSp4PeViL70tVZCfRyRIKM7Pks/gR9+1c5gQ8LslCE SwlnwVu44kJZYljS4J28VFqBfsedgtIbfgNV+mKLPBwX5dG6ZrZh4GpFUgasRfkCN2d6Cpe4XhaKk vZKrFRVJp4LlVBwycN4++0xmAyx8gkb59zc4Q/ObQ6dGehVPbiL5bLdNO++PT2MbsqGzl+qcZAJ1o jV+e2RD+b6OxzRYZB3sHiu2ugQDMIiokhnWGSmZdK3BgXAXapjC1f5WzNYiljdPWmKNgGgdFNCi8F mIdXxPTw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIXGU-00B9sS-0V; Tue, 24 Aug 2021 14:19:23 +0000 Date: Tue, 24 Aug 2021 15:18:57 +0100 From: Matthew Wilcox To: David Howells Cc: Jeffrey Altman , linux-afs@lists.infradead.org, Jeff Layton , Ilya Dryomov , linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, devel@lists.orangefs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] afs: Fix afs_launder_page() to set correct start file position Message-ID: References: <162981147473.1901565.1455657509200944265.stgit@warthog.procyon.org.uk> <162981148752.1901565.3663780601682206026.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162981148752.1901565.3663780601682206026.stgit@warthog.procyon.org.uk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 24, 2021 at 02:24:47PM +0100, David Howells wrote: > +++ b/fs/afs/write.c > @@ -950,8 +950,8 @@ int afs_launder_page(struct page *page) > iov_iter_bvec(&iter, WRITE, bv, 1, bv[0].bv_len); > > trace_afs_page_dirty(vnode, tracepoint_string("launder"), page); > - ret = afs_store_data(vnode, &iter, (loff_t)page->index * PAGE_SIZE, > - true); > + ret = afs_store_data(vnode, &iter, > + (loff_t)page->index * PAGE_SIZE + f, true); This could be page_offset(page), which reads better to me: ret = afs_store_data(vnode, &iter, page_offset(page) + f, true);