From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78F48C4338F for ; Tue, 24 Aug 2021 16:54:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D3D561357 for ; Tue, 24 Aug 2021 16:54:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232644AbhHXQzh (ORCPT ); Tue, 24 Aug 2021 12:55:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232732AbhHXQzZ (ORCPT ); Tue, 24 Aug 2021 12:55:25 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B302C061757 for ; Tue, 24 Aug 2021 09:54:33 -0700 (PDT) Received: from zn.tnic (p200300ec2f11440049ee8a07127e6a59.dip0.t-ipconnect.de [IPv6:2003:ec:2f11:4400:49ee:8a07:127e:6a59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 104521EC04D1; Tue, 24 Aug 2021 18:54:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1629824068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=oucuOJ/6VvgUop2x1OI+HAFbSiUqa9pO9eiBxTDjqDU=; b=PNEDFxELl/eP785dgUGCkCL/yDSv4Uo0/Rl1JC8Eu0NqLPFsnSOJ+Q+m1oGl+c29okCpDn EXyBrlRojKbgqSvZGqwfTpkMep3+tae08RF6aIF6VwerwELWPpa/7uYP8qPa8pS04UnRqh enUQNP6+Cp7riAoIVAghu8QXIfRDQmI= Date: Tue, 24 Aug 2021 18:55:05 +0200 From: Borislav Petkov To: Kuppuswamy Sathyanarayanan Cc: Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Andy Lutomirski , Peter H Anvin , Dave Hansen , Tony Luck , Dan Williams , Andi Kleen , Kirill Shutemov , Sean Christopherson , Kuppuswamy Sathyanarayanan , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 10/12] x86/tdx: Add MSR support for TDX guest Message-ID: References: <20210804181329.2899708-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20210804181329.2899708-11-sathyanarayanan.kuppuswamy@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210804181329.2899708-11-sathyanarayanan.kuppuswamy@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 04, 2021 at 11:13:27AM -0700, Kuppuswamy Sathyanarayanan wrote: > int tdg_handle_virtualization_exception(struct pt_regs *regs, > struct ve_info *ve) > { > + unsigned long val; > + int ret = 0; > + > switch (ve->exit_reason) { > case EXIT_REASON_HLT: > tdg_halt(); > break; > + case EXIT_REASON_MSR_READ: > + val = tdg_read_msr_safe(regs->cx, (unsigned int *)&ret); > + if (!ret) { > + regs->ax = val & UINT_MAX; regs->ax = (u32)val; > + regs->dx = val >> 32; > + } > + break; > + case EXIT_REASON_MSR_WRITE: > + ret = tdg_write_msr_safe(regs->cx, regs->ax, regs->dx); > + break; > default: > pr_warn("Unexpected #VE: %lld\n", ve->exit_reason); > return -EFAULT; > } > > /* After successful #VE handling, move the IP */ > - regs->ip += ve->instr_len; > + if (!ret) > + regs->ip += ve->instr_len; > > - return 0; > + return ret; > } > > void __init tdx_early_init(void) > -- -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette