From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: sbillaka@codeaurora.org
Cc: Stephen Boyd <swboyd@chromium.org>,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
robdclark@gmail.com, seanpaul@chromium.org,
kalyan_t@codeaurora.org, abhinavk@codeaurora.org,
dianders@chromium.org, khsieh@codeaurora.org,
mkrishn@codeaurora.org
Subject: Re: [PATCH v1 1/2] drm/msm/dp: Add support for SC7280 eDP
Date: Wed, 25 Aug 2021 18:11:48 -0500 [thread overview]
Message-ID: <YSbONPNITH6dIECr@builder.lan> (raw)
In-Reply-To: <0b2aa426c8f511a29143f2a1117fe9a2@codeaurora.org>
On Thu 12 Aug 19:28 CDT 2021, sbillaka@codeaurora.org wrote:
> On 2021-08-12 06:11, Stephen Boyd wrote:
> > Quoting Sankeerth Billakanti (2021-08-11 17:08:01)
[..]
> > > +static int dp_parser_gpio(struct dp_parser *parser)
> > > +{
> > > + struct device *dev = &parser->pdev->dev;
> > > + int ret;
> > > +
> > > + parser->panel_bklt_gpio = devm_gpiod_get(dev, "panel-bklt",
> > > + GPIOD_OUT_HIGH);
> > > + if (IS_ERR(parser->panel_bklt_gpio)) {
> > > + ret = PTR_ERR(parser->panel_bklt_gpio);
> > > + parser->panel_bklt_gpio = NULL;
> > > + DRM_ERROR("%s: cannot get panel-bklt gpio, %d\n",
> > > __func__, ret);
> > > + goto fail;
> > > + }
> > > +
> > > + parser->panel_pwm_gpio = devm_gpiod_get(dev, "panel-pwm",
> > > GPIOD_OUT_HIGH);
> > > + if (IS_ERR(parser->panel_pwm_gpio)) {
> > > + ret = PTR_ERR(parser->panel_pwm_gpio);
> > > + parser->panel_pwm_gpio = NULL;
> > > + DRM_ERROR("%s: cannot get panel-pwm gpio, %d\n",
> > > __func__, ret);
> > > + goto fail;
> > > + }
> > > +
> > > + DRM_INFO("gpio on");
> > > +fail:
> > > + return 0;
> > > +}
> >
> > Don't we have pwm backlight drivers like
> > drivers/video/backlight/pwm_bl.c to support this? This sort of thing
> > doesn't belong in the dp driver.
>
> Okay. I will explore it.
>
I proposed that we attach a drm_panel and allow that to control the
(pwm-)backlight. Here's the link for the DP patch:
https://lore.kernel.org/linux-arm-msm/20210726231351.655302-1-bjorn.andersson@linaro.org/
Regards,
Bjorn
next prev parent reply other threads:[~2021-08-25 23:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 0:08 [PATCH v1 0/2] Add support for eDP on SC7280 Sankeerth Billakanti
2021-08-12 0:08 ` [PATCH v1 1/2] drm/msm/dp: Add support for SC7280 eDP Sankeerth Billakanti
2021-08-12 0:41 ` Stephen Boyd
2021-08-13 0:28 ` sbillaka
2021-08-25 23:11 ` Bjorn Andersson [this message]
2021-08-16 17:51 ` Matthias Kaehlcke
2021-09-14 3:53 ` Stephen Boyd
2021-08-12 0:08 ` [PATCH v1 2/2] dt-bindings: Add SC7280 compatible string Sankeerth Billakanti
2021-08-12 0:31 ` Stephen Boyd
2021-08-16 18:01 ` Matthias Kaehlcke
2021-08-24 23:07 ` Doug Anderson
2021-08-25 17:50 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSbONPNITH6dIECr@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=abhinavk@codeaurora.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=kalyan_t@codeaurora.org \
--cc=khsieh@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrishn@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=sbillaka@codeaurora.org \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).