From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bryan Brattlof <hello@bryanbrattlof.com>
Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/5] staging: rtl8723bs: remove unused functions
Date: Thu, 26 Aug 2021 12:04:45 +0200 [thread overview]
Message-ID: <YSdnPavatnKCVmqy@kroah.com> (raw)
In-Reply-To: <20210822204212.2832397-1-hello@bryanbrattlof.com>
On Sun, Aug 22, 2021 at 08:42:58PM +0000, Bryan Brattlof wrote:
> Changes in v2:
> - Remove build warnings I introduced in the previous version.
>
> ***
>
> There is a lot of un-used code and un-needed abstractions leftover
> in this driver from when (I assume) it could be compiled on more than
> one kernel.
>
> This series removes dead code and is one small step toward
> refactoring how this driver interacts with the SDIO subsystem.
>
Better, but these are still not threaded properly (some were, patches 1
and 2, but not the rest.)
Please fix up and resend a v3.
thanks,
greg k-h
prev parent reply other threads:[~2021-08-26 10:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 20:42 [PATCH v2 0/5] staging: rtl8723bs: remove unused functions Bryan Brattlof
2021-08-22 20:43 ` [PATCH v2 1/5] staging: rtl8723bs: remove sdio_write_mem() Bryan Brattlof
2021-08-22 20:43 ` [PATCH v2 2/5] staging: rtl8723bs: remove sdio_writeN() Bryan Brattlof
2021-08-26 10:04 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSdnPavatnKCVmqy@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fmdefrancesco@gmail.com \
--cc=hello@bryanbrattlof.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).