From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DD4FC432BE for ; Thu, 26 Aug 2021 10:39:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 748F0610CB for ; Thu, 26 Aug 2021 10:39:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241498AbhHZKkQ (ORCPT ); Thu, 26 Aug 2021 06:40:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:49260 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233929AbhHZKkP (ORCPT ); Thu, 26 Aug 2021 06:40:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6C8576108E; Thu, 26 Aug 2021 10:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1629974368; bh=Kb2BRqJnhgCEFtwwhEQxATLUmyDZuDxe9+QdYedO9iM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DzAxaPWoy2aAMRtvCvBRb/MtNk0GOEfGvNTAb+0dDMr59Aa6AvhC+P2RetXyksCsH VR64JQaY2QUT2r3iw3dZvifvkB1KOAOsIm41qyEKBI17QuwkyOqcvH7EsWO+0SJXAG X2Uec6IjXwEhBTHYBUSGXYFHi23sHVjxutjgFBsI= Date: Thu, 26 Aug 2021 12:39:23 +0200 From: Greg KH To: Pavel Skripkin Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, fmdefrancesco@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] staging: r8188eu: remove {read,write}_macreg Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 24, 2021 at 10:27:13AM +0300, Pavel Skripkin wrote: > These 2 functions are unused, so they can be simply removed > > Signed-off-by: Pavel Skripkin > --- > drivers/staging/r8188eu/core/rtw_mp.c | 39 ------------------------ > drivers/staging/r8188eu/include/rtw_mp.h | 2 -- > 2 files changed, 41 deletions(-) write_macreg_hdl and the read version can also be removed, right? thanks, greg k-h