From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29805C43214 for ; Thu, 26 Aug 2021 12:53:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 028F560F39 for ; Thu, 26 Aug 2021 12:53:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242255AbhHZMxs (ORCPT ); Thu, 26 Aug 2021 08:53:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:60304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233687AbhHZMxq (ORCPT ); Thu, 26 Aug 2021 08:53:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BD68060184; Thu, 26 Aug 2021 12:52:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629982379; bh=XHhGpjY0FA2y0UYa/0RXWRkT6z4HWanfCrqmAUxRmO8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uTiaD/jEL++G5HYo4eHyvw6VjyMszGD8TQHVq2zS0Ton8am0AB5iST1JevpEsS6kK vGYfEiGUbBNVDbLAXcy0brHC47rBC52Ba2jRCvPWUSS9s9Dt17Kk8tjErije2rPXLj LktqGb733czXFrFPolxzku+wRqq9ecVBKxDHsLvpspbrKJfyKjnb7Pz1170OS75B/x +CMA45L0SYcBCsDP+XR5yFW049hWu09HGQVPbZyicML2lTd5u1xHmcvFPLBI8h7mJx 6dopyD6b4IUr5DbZP4ir5YLSyzGg4/ToMbt1jwd1przuHDv6BlbqSI9SnVtunWIvjz Y6resBAhV9SqA== Date: Thu, 26 Aug 2021 18:22:55 +0530 From: Vinod Koul To: Daniel Thompson Cc: Andy Shevchenko , Jonathan Corbet , dmaengine , Linux Documentation List , Linux Kernel Mailing List , patches@linaro.org, Haavard Skinnemoen , =?iso-8859-1?Q?H=E5vard?= Skinnemoen Subject: Re: [PATCH 1/2] Documentation: dmaengine: Add a description of what dmatest does Message-ID: References: <20210818151315.9505-1-daniel.thompson@linaro.org> <20210818151315.9505-2-daniel.thompson@linaro.org> <20210819091328.6up4oprx4j7u5bjl@maple.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210819091328.6up4oprx4j7u5bjl@maple.lan> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19-08-21, 10:13, Daniel Thompson wrote: > On Wed, Aug 18, 2021 at 06:27:52PM +0300, Andy Shevchenko wrote: > > On Wed, Aug 18, 2021 at 6:15 PM Daniel Thompson > > wrote: > > > > > > Currently it can difficult to determine what dmatest does without > > > reading the source code. Let's add a description. > > > > > > The description is taken mostly from the patch header of > > > commit 4a776f0aa922 ("dmatest: Simple DMA memcpy test client") > > > although it has been edited and updated slightly. > > > > > Signed-off-by: Haavard Skinnemoen > > > > Not sure if you can use it like this (I mean the above SoB) > > I wondered about that. > > In the end I concluded that if I had picked up code from an old patch > and edited to this degree then I would probably consider it a new > patch but be clear about credit and preserve the original SoB. I saw no > real reason to treat the contents of a patch header much different. > > However, I'm very happy to make the credit more informal if needed. It would be better if we be formal when giving credit. I am okay with sob by Haavard if he acks it... Daniel, Yes the intention is very noble, but I would have Haavard ack before applying a patch with his sob, if not lets drop it and give credit in changelog :) -- ~Vinod