From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E682C4320A for ; Thu, 26 Aug 2021 19:51:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 260D160F11 for ; Thu, 26 Aug 2021 19:51:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243446AbhHZTwZ (ORCPT ); Thu, 26 Aug 2021 15:52:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230085AbhHZTwY (ORCPT ); Thu, 26 Aug 2021 15:52:24 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3021BC0613C1 for ; Thu, 26 Aug 2021 12:51:37 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id fz10so2972990pjb.0 for ; Thu, 26 Aug 2021 12:51:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VDKSZwM6+MkspeAfVSvtL1ryQMnZ/8yIsg8vSwepJrk=; b=kKU5fomT08zxgo0C6ur54X+WSdXkohiKvaojhLd65QKKOp1DUTy43t4weo5hEyBW0/ LGi2JAL/MobSKVsax+S4xp7F94wJP8F7bkEgpyVd/1FkDLxw1NPGL00nkQRIl9kaXcls zVTo+8SrCNlubKZsH42QWBHs3OLWvlCkPkTnk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VDKSZwM6+MkspeAfVSvtL1ryQMnZ/8yIsg8vSwepJrk=; b=DyBNhX+Y+QFcs9eOtXKKBHV43/megHbMX7l13a7351sZHqiGHsvOeICVj5HODaaZVA eGw8kpgErjdMrYoT1lJtsLfrLO4d5OUqg7dYdwvPGfLXYFsqKrE69wxhqyhla4gZqe74 3YHXbC1Koq1t+GBMhmW9KND6O3nQP4epBIHQwYqH9Usel+c/xfgLwV+jtlFHa9UaaXm0 gZOSp/obQaiF+jyD3a4mUi4aYLrsAAOwmY5hUnjlPJo/0jvke9EUFPKZnlyckLROgoh8 UoWXndwBmLfQL/jperwqT84KTQHY8MpaWVc9Mq2VUFwwM7KOAqoMmvUd3kmFjMqGvvEN ZNIg== X-Gm-Message-State: AOAM532XxUplZD2fecyq6IWg0ndr0MsH2eDJfturs/IapDR9xlaVnp8L EK39AVl11zYHimP+GtjOR6Q6Hg== X-Google-Smtp-Source: ABdhPJx6mpM4H0UsaVPSAz7cl4fw0b0Mrl9F8syKLHFXkbN/VITueXvFSZJ84fZAJAYlW/wHoRFHIw== X-Received: by 2002:a17:90a:9f91:: with SMTP id o17mr18336584pjp.29.1630007496692; Thu, 26 Aug 2021 12:51:36 -0700 (PDT) Received: from localhost ([2620:15c:202:201:bd0b:bcb8:ebdb:c24d]) by smtp.gmail.com with UTF8SMTPSA id z8sm3749169pfa.113.2021.08.26.12.51.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Aug 2021 12:51:36 -0700 (PDT) Date: Thu, 26 Aug 2021 12:51:34 -0700 From: Matthias Kaehlcke To: rajpat@codeaurora.org Cc: Andy Gross , Bjorn Andersson , Rob Herring , swboyd@chromium.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, rnayak@codeaurora.org, saiprakash.ranjan@codeaurora.org, msavaliy@qti.qualcomm.com, skakit@codeaurora.org Subject: Re: [PATCH V5 3/7] arm64: dts: sc7280: Add QUPv3 wrapper_0 nodes Message-ID: References: <1628754078-29779-1-git-send-email-rajpat@codeaurora.org> <1628754078-29779-4-git-send-email-rajpat@codeaurora.org> <114d7419b0a85fcacf775cc34f279f0e@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <114d7419b0a85fcacf775cc34f279f0e@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 26, 2021 at 06:37:02PM +0530, rajpat@codeaurora.org wrote: > On 2021-08-12 19:44, Matthias Kaehlcke wrote: > > On Thu, Aug 12, 2021 at 01:11:14PM +0530, Rajesh Patil wrote: > > > From: Roja Rani Yarubandi > > > > > > Add QUPv3 wrapper_0 DT nodes for SC7280 SoC. > > > > > > Signed-off-by: Roja Rani Yarubandi > > > Signed-off-by: Rajesh Patil > > > --- > > > arch/arm64/boot/dts/qcom/sc7280.dtsi | 720 > > > +++++++++++++++++++++++++++++++++++ > > > 1 file changed, 720 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > b/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > index f8dd5ff..e461395 100644 > > > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > > > > ... > > > > > > + spi0: spi@980000 { > > > + compatible = "qcom,geni-spi"; > > > + reg = <0 0x00980000 0 0x4000>; > > > + clock-names = "se"; > > > + clocks = <&gcc GCC_QUPV3_WRAP0_S0_CLK>; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&qup_spi0_data_clk>, <&qup_spi0_cs>, > > > <&qup_spi0_cs_gpio>; > > > > What is the story behind 'qup_spiN_cs' and 'qup_spiN_cs_gpio'? Both > > configure > > the CS pin with a different function: > > > > As per discussion here [1], we have split like this. > > [1] https://lore.kernel.org/patchwork/patch/1393353/#1591826 IIUC that's only about having separate configs for each pin, instead of groups like 'qup-spi0-default'. What you are doing above with 'qup_spi0_cs' and 'qup_spi0_cs_gpio' is to configure the same pin (GPIO 3) both as SPI chip select and as GPIO. Which one is it? I imagine we want to have both pinctrl definitions to allow a board to configure the pin either as SPI CS or GPIO. However it should be only one of the two at a time, and the SoC .dtsi should provide a reasonable default, which probably is SPI CS. Maybe I'm missing something, if so please provide details on why it is necessary to have this config.