From: Andrew Lunn <andrew@lunn.ch>
To: Saravana Kannan <saravanak@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Len Brown <lenb@kernel.org>,
Alvin Sipraga <ALSI@bang-olufsen.dk>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v1 1/2] driver core: fw_devlink: Add support for FWNODE_FLAG_BROKEN_PARENT
Date: Fri, 27 Aug 2021 03:23:01 +0200 [thread overview]
Message-ID: <YSg+dRPSX9/ph6tb@lunn.ch> (raw)
In-Reply-To: <CAGETcx_h6moWbS7m4hPm6Ub3T0tWayUQkppjevkYyiA=8AmACw@mail.gmail.com>
> Doesn't add much to the discussion. In the example I gave, the driver
> already does synchronous probing. If the device can't probe
> successfully because a supplier isn't ready, it doesn't matter if it's
> a synchronous probe. The probe would still be deferred and we'll hit
> the same issue. Even in the situation the commit [5] describes, if
> parallelized probing is done and the PHY depended on something (say a
> clock), you'd still end up not probing the PHY even if the driver is
> present and the generic PHY would end up force probing it.
genphy is meant to be used when there is no other driver available.
It is a best effort, better than nothing, might work. And quite a few
boards rely on it. However, it should not be used when there is a
specific driver.
So if the PHY device has been probed, and -EPROBE_DEFER was returned,
we also need to return -EPROBE_DEFER here when deciding if genphy
should be used. It should then all unwind and try again later.
I don't know the device core, but it looks like dev->can_match tells
us what we need to know. If true, we know there is a driver for this
device. But i'm hesitant to make use of this outside of driver/base.
Andrew
next prev parent reply other threads:[~2021-08-27 1:23 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 7:45 [PATCH v1 0/2] Fix rtl8366rb issues with fw_devlink=on Saravana Kannan
2021-08-26 7:45 ` [PATCH v1 1/2] driver core: fw_devlink: Add support for FWNODE_FLAG_BROKEN_PARENT Saravana Kannan
2021-08-26 13:13 ` Andrew Lunn
2021-08-26 19:56 ` Saravana Kannan
2021-08-26 20:53 ` Andrew Lunn
2021-08-26 23:44 ` Saravana Kannan
2021-08-27 1:23 ` Andrew Lunn [this message]
2021-08-27 4:02 ` Saravana Kannan
2021-08-27 13:44 ` Andrew Lunn
2021-08-27 18:06 ` Saravana Kannan
2021-08-27 20:11 ` Andrew Lunn
2021-08-27 21:33 ` Saravana Kannan
2021-08-28 17:01 ` Andrew Lunn
2021-08-30 19:03 ` Saravana Kannan
2021-08-31 13:16 ` Andrew Lunn
2021-08-31 19:26 ` Saravana Kannan
2021-08-31 22:05 ` Andrew Lunn
2021-08-31 22:18 ` Saravana Kannan
2021-08-31 23:02 ` Andrew Lunn
2021-08-31 23:18 ` Vladimir Oltean
2021-08-31 23:27 ` Andrew Lunn
2021-09-01 1:28 ` Vladimir Oltean
2021-09-01 1:38 ` Vladimir Oltean
2021-09-01 2:19 ` Saravana Kannan
2021-09-01 9:02 ` Vladimir Oltean
2021-09-01 22:57 ` Saravana Kannan
2021-09-01 2:00 ` Saravana Kannan
2021-09-01 8:46 ` Vladimir Oltean
2021-09-01 22:53 ` Saravana Kannan
2021-09-02 17:41 ` Andrew Lunn
2021-09-02 17:58 ` Saravana Kannan
2021-09-30 5:33 ` Saravana Kannan
2021-09-30 13:15 ` Andrew Lunn
2021-09-30 13:43 ` Vladimir Oltean
2021-09-30 14:00 ` Andrew Lunn
2021-09-30 17:31 ` Saravana Kannan
2021-09-30 19:38 ` Andrew Lunn
2021-09-30 19:48 ` Saravana Kannan
2021-09-30 20:06 ` Florian Fainelli
2021-09-30 20:14 ` Saravana Kannan
2021-09-30 21:16 ` Florian Fainelli
2021-09-30 20:22 ` Andrew Lunn
2021-09-01 1:46 ` Saravana Kannan
2021-08-31 23:18 ` Andrew Lunn
2021-09-08 18:35 ` Saravana Kannan
2021-09-09 1:39 ` Andrew Lunn
2021-09-09 3:21 ` Saravana Kannan
2021-09-09 10:38 ` Vladimir Oltean
2021-09-09 15:00 ` Andrew Lunn
2021-09-09 16:56 ` Florian Fainelli
2021-08-26 7:45 ` [PATCH v1 2/2] net: dsa: rtl8366rb: Quick fix to work with fw_devlink=on Saravana Kannan
2021-08-26 7:55 ` Greg Kroah-Hartman
2021-08-26 11:25 ` Florian Fainelli
2021-08-26 17:29 ` Saravana Kannan
2021-08-26 11:29 ` Alvin Šipraga
2021-08-26 17:26 ` Saravana Kannan
2021-08-26 18:04 ` Alvin Šipraga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSg+dRPSX9/ph6tb@lunn.ch \
--to=andrew@lunn.ch \
--cc=ALSI@bang-olufsen.dk \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).