From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: kernel-janitors <kernel-janitors@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Colin King <colin.king@canonical.com>
Subject: Re: [PATCH] parport: remove non-zero check on count
Date: Fri, 27 Aug 2021 16:18:55 +0200 [thread overview]
Message-ID: <YSj0Tz8DwstOy4nG@kroah.com> (raw)
In-Reply-To: <CADVatmOudaqZBr+cX_AXwKmDRd2LRTe=C=_bavEki0fdhWkADg@mail.gmail.com>
On Thu, Aug 19, 2021 at 09:52:07PM +0100, Sudip Mukherjee wrote:
> On Fri, Jul 30, 2021 at 11:07 AM Colin King <colin.king@canonical.com> wrote:
> >
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The check for count appears to be incorrect since a non-zero count
> > check occurs a couple of statements earlier. Currently the check is
> > always false and the dev->port->irq != PARPORT_IRQ_NONE part of the
> > check is never tested and the if statement is dead-code. Fix this
> > by removing the check on count.
> >
> > Note that this code is pre-git history, so I can't find a sha for
> > it.
> >
> > Addresses-Coverity: ("Logically dead code")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
>
> Greg, can you please take it through your tree..
> I think you might not have it in your queue as you were not in the
> original recipient list, if so, I can send it after adding my Ack to
> it.
Now picked up, thanks.
greg k-h
prev parent reply other threads:[~2021-08-27 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 10:07 [PATCH] parport: remove non-zero check on count Colin King
2021-08-19 20:52 ` Sudip Mukherjee
2021-08-27 14:18 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSj0Tz8DwstOy4nG@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).