From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5084C4320A for ; Fri, 27 Aug 2021 17:14:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9991660F5B for ; Fri, 27 Aug 2021 17:14:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236724AbhH0RPL (ORCPT ); Fri, 27 Aug 2021 13:15:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235700AbhH0RPK (ORCPT ); Fri, 27 Aug 2021 13:15:10 -0400 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25172C061757 for ; Fri, 27 Aug 2021 10:14:21 -0700 (PDT) Received: by mail-ot1-x336.google.com with SMTP id a20-20020a0568300b9400b0051b8ca82dfcso8820150otv.3 for ; Fri, 27 Aug 2021 10:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zK3aiufjz7ahPa7Tc/uovDrwODHk5O2Kax7tz64cLHE=; b=YuifmkEni1937iAfOjJjARdxFbdIen3tmwXAIKXv6RGYhhnthKze+CAp7xWygPqZ2V jvKYzEDU/bXZMRVa6XsJWufP3VYUcvx72KRPQLZC/3IYU8y17UJn7qGw+WcobkYhFSfI hfpxFlU8qnrvMwB22ycY2JsSjUqRjtSKhkG0pWSmuyStkzuzYnLvyHhpiCe6WppU7+YP UD5EYnJx0kTEeyGbQclFz0ofNKccVPPA0jyMmP3eMZLt4klokE6AfjTkB88YISQT59Sv z2CllTUuAAToJpg2d6zh4kqnxAKi1i+BOUbg+JDtZgpKHQiWF02QJzluhDn/dpCAAkOz QQKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zK3aiufjz7ahPa7Tc/uovDrwODHk5O2Kax7tz64cLHE=; b=FQ5v+OkD/RLEuQA14rGFTdoYsWCKbCfaIbLgmGkN8OEEyPeFOdVqxCKCneJtxROZ46 ZvLwV3Jfg1eKMHqcr/Tb7RMuIddAghf8ZVLoQY1vSYf1XRWeQfKnepYkDtI7TpGan4Sd /RHLCe+K6sjZdCNVHdwwh0zFA7ndxMYoQYnNpssudcYEE7C0GRUKIqM5gklsvYSHO5AY II3+He+mcoaBYXYMu/Vvp1N/LnIQfRrpeTS69cbZ+4WbewoS/UQg9NTYOu0Zy/0O5p1D 7dWiQ/eK3obiFPx0a1ckeCnM7tcHacdcgzEm4HhM7f776biRD5Bnvk16MwHHPYjSe208 xs3A== X-Gm-Message-State: AOAM530sS0Prx5c8wnmCkgl/MhRIfKnxDM/SntfmIUr1WpGNDrb3IRPK liD5sPwuxmPzPBmbiIVTXdaKIw== X-Google-Smtp-Source: ABdhPJzaUbwWRzaLBbQulWdsE0TFLXvYUc7WuweJbzC1OcohmnizQZGT5Bcx7GOFfJfYOs4CenHf8A== X-Received: by 2002:a05:6830:4196:: with SMTP id r22mr9319481otu.231.1630084460503; Fri, 27 Aug 2021 10:14:20 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id q13sm1330942ota.17.2021.08.27.10.14.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Aug 2021 10:14:20 -0700 (PDT) Date: Fri, 27 Aug 2021 12:14:18 -0500 From: Bjorn Andersson To: Stephen Boyd Cc: Abhinav Kumar , Daniel Vetter , David Airlie , Dmitry Baryshkov , Kalyan Thota , Kuogee Hsieh , Rob Clark , Sean Paul , Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/5] drm/msm/dp: Support up to 3 DP controllers Message-ID: References: <20210825234233.1721068-1-bjorn.andersson@linaro.org> <20210825234233.1721068-4-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 27 Aug 00:20 CDT 2021, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-08-25 16:42:31) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > > index 2c7de43f655a..4a6132c18e57 100644 > > --- a/drivers/gpu/drm/msm/dp/dp_display.c > > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > > @@ -78,6 +78,8 @@ struct dp_display_private { > > char *name; > > int irq; > > > > + int id; > > + > > /* state variables */ > > bool core_initialized; > > bool hpd_irq_on; > > @@ -115,8 +117,19 @@ struct dp_display_private { > > struct dp_audio *audio; > > }; > > > > + > > +struct msm_dp_config { > > + phys_addr_t io_start[3]; > > Can this be made into another struct, like msm_dp_desc, that also > indicates what type of DP connector it is, i.e. eDP vs DP? That would > help me understand in modetest and /sys/class/drm what sort of connector > is probing. dp_drm_connector_init() would need to pass the type of > connector appropriately. Right now, eDP connectors still show up as DP > instead of eDP in sysfs. > I like it, will spin a v3 with this. Regards, Bjorn > > + size_t num_dp; > > +}; > > + > > +static const struct msm_dp_config sc7180_dp_cfg = { > > + .io_start = { 0x0ae90000 }, > > + .num_dp = 1, > > +}; > > + > > static const struct of_device_id dp_dt_match[] = { > > - {.compatible = "qcom,sc7180-dp"}, > > + { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg }, > > {} > > }; > >