From: Andrew Lunn <andrew@lunn.ch>
To: Matthew Hagan <mnhagan88@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] ARM: dts: NSP: Fix MDIO mux node names
Date: Sun, 29 Aug 2021 00:14:17 +0200 [thread overview]
Message-ID: <YSq1OS+z8KKcUdu5@lunn.ch> (raw)
In-Reply-To: <858a86de-c06e-0221-64ea-bb1790db398a@gmail.com>
On Sat, Aug 28, 2021 at 10:52:30PM +0100, Matthew Hagan wrote:
> On 28/08/2021 18:07, Andrew Lunn wrote:
>
> > On Sat, Aug 28, 2021 at 11:27:01AM +0000, Matthew Hagan wrote:
> >> This patch fixes the following message by adding "mdio-mux" compatible:
> >> compatible: ['mdio-mux-mmioreg'] is too short
> >
> > Err, what? This sounds like a workaround for a tool problem, not a
> > real fix.
> >
> > What is actually wrong with:
> >
> > compatible = "mdio-mux-mmioreg";
>
> Yes this does work fine either with or without "mdio-mux". The changes
> have been made to correspond with those submitted by Rafal Milecki for
> the BCM5301X platform[1] and to conform with
> Documentation/devicetree/bindings/net/mdio-mux-mmioreg.yaml
> which does state both as required items (and hence not a tool problem).
Hi Matthew
It would be good to expand the commit message a bit, since the error
'is too short' is particularly uninformative, and leads to questions
like this if not explained.
It would also good to get the tool improved, but that is out of scope
for this patch.
Andrew
next prev parent reply other threads:[~2021-08-28 22:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 11:26 [PATCH 1/5] ARM: dts: NSP: Add bcm958623hr board name to dts Matthew Hagan
2021-08-28 11:27 ` [PATCH 2/5] ARM: dts: NSP: Fix mpcore, mmc node names Matthew Hagan
2021-08-28 11:27 ` [PATCH 3/5] ARM: dts: NSP: Fix MDIO mux " Matthew Hagan
2021-08-28 17:07 ` Andrew Lunn
2021-08-28 21:52 ` Matthew Hagan
2021-08-28 22:14 ` Andrew Lunn [this message]
2021-09-16 12:52 ` Andrew Lunn
2021-08-28 11:27 ` [PATCH 4/5] ARM: dts: NSP: Fix MX64/MX65 eeprom node name Matthew Hagan
2021-08-28 11:27 ` [PATCH 5/5] ARM: dts: NSP: Fix MX65 MDIO mux warnings Matthew Hagan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSq1OS+z8KKcUdu5@lunn.ch \
--to=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mnhagan88@gmail.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).