From: Jiri Olsa <jolsa@redhat.com>
To: Riccardo Mancini <rickyman7@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>
Subject: Re: [RFC PATCH v3 07/15] perf workqueue: implement worker thread and management
Date: Mon, 30 Aug 2021 09:22:47 +0200 [thread overview]
Message-ID: <YSyHR7aP0OieedgE@krava> (raw)
In-Reply-To: <e88e4e61309845043d1f0939b5c33cd60e9d3ed5.1629454773.git.rickyman7@gmail.com>
On Fri, Aug 20, 2021 at 12:53:53PM +0200, Riccardo Mancini wrote:
SNIP
> /**
> * create_workqueue - create a workqueue associated to @pool
> *
> @@ -41,7 +361,8 @@ static const char * const workqueue_errno_str[] = {
> */
> struct workqueue_struct *create_workqueue(int nr_threads)
> {
> - int ret, err = 0;
> + int ret, err = 0, t;
> + struct worker *worker;
> struct workqueue_struct *wq = zalloc(sizeof(struct workqueue_struct));
>
> if (!wq) {
> @@ -56,10 +377,16 @@ struct workqueue_struct *create_workqueue(int nr_threads)
> goto out_free_wq;
> }
>
> + wq->workers = calloc(nr_threads, sizeof(*wq->workers));
> + if (!wq->workers) {
> + err = -ENOMEM;
> + goto out_delete_pool;
> + }
> +
> ret = pthread_mutex_init(&wq->lock, NULL);
> if (ret) {
> err = -ret;
> - goto out_delete_pool;
> + goto out_free_workers;
> }
>
> ret = pthread_cond_init(&wq->idle_cond, NULL);
> @@ -77,12 +404,41 @@ struct workqueue_struct *create_workqueue(int nr_threads)
> goto out_destroy_cond;
> }
>
> + wq->task.fn = worker_thread;
> +
> + wq->pool_errno = threadpool__execute(wq->pool, &wq->task);
> + if (wq->pool_errno) {
> + err = -WORKQUEUE_ERROR__POOLEXE;
> + goto out_close_pipe;
> + }
hum, why the threadpool__execute in here? threads are not runnig at this
point, so nothing will happen right?
jirka
> +
> + for (t = 0; t < nr_threads; t++) {
> + err = spinup_worker(wq, t);
> + if (err)
> + goto out_stop_pool;
> + }
> +
> return wq;
>
> +out_stop_pool:
> + lock_workqueue(wq);
> + for_each_idle_worker(wq, worker) {
> + ret = stop_worker(worker);
> + if (ret)
> + err = ret;
> + }
> + unlock_workqueue(wq);
> +out_close_pipe:
> + close(wq->msg_pipe[0]);
> + wq->msg_pipe[0] = -1;
> + close(wq->msg_pipe[1]);
> + wq->msg_pipe[1] = -1;
> out_destroy_cond:
> pthread_cond_destroy(&wq->idle_cond);
> out_destroy_mutex:
> pthread_mutex_destroy(&wq->lock);
> +out_free_workers:
> + free(wq->workers);
> out_delete_pool:
> threadpool__delete(wq->pool);
> out_free_wq:
> @@ -96,12 +452,27 @@ struct workqueue_struct *create_workqueue(int nr_threads)
> */
SNIP
next prev parent reply other threads:[~2021-08-30 7:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 10:53 [RFC PATCH v3 00/15] perf: add workqueue library and use it in synthetic-events Riccardo Mancini
2021-08-20 10:53 ` [RFC PATCH v3 01/15] perf workqueue: threadpool creation and destruction Riccardo Mancini
2021-08-20 10:53 ` [RFC PATCH v3 02/15] perf tests: add test for workqueue Riccardo Mancini
2021-08-20 10:53 ` [RFC PATCH v3 03/15] perf workqueue: add threadpool start and stop functions Riccardo Mancini
2021-08-20 10:53 ` [RFC PATCH v3 04/15] perf workqueue: add threadpool execute and wait functions Riccardo Mancini
2021-08-20 10:53 ` [RFC PATCH v3 05/15] tools: add sparse context/locking annotations in compiler-types.h Riccardo Mancini
2021-08-20 10:53 ` [RFC PATCH v3 06/15] perf workqueue: introduce workqueue struct Riccardo Mancini
2021-08-24 19:27 ` Namhyung Kim
2021-08-31 16:13 ` Riccardo Mancini
2021-08-20 10:53 ` [RFC PATCH v3 07/15] perf workqueue: implement worker thread and management Riccardo Mancini
2021-08-30 7:22 ` Jiri Olsa [this message]
2021-08-20 10:53 ` [RFC PATCH v3 08/15] perf workqueue: add queue_work and flush_workqueue functions Riccardo Mancini
2021-08-24 19:40 ` Namhyung Kim
2021-08-31 16:23 ` Riccardo Mancini
2021-08-20 10:53 ` [RFC PATCH v3 09/15] perf workqueue: spinup threads when needed Riccardo Mancini
2021-08-20 10:53 ` [RFC PATCH v3 10/15] perf workqueue: create global workqueue Riccardo Mancini
2021-08-20 10:53 ` [RFC PATCH v3 11/15] perf workqueue: add utility to execute a for loop in parallel Riccardo Mancini
2021-08-20 10:53 ` [RFC PATCH v3 12/15] perf record: setup global workqueue Riccardo Mancini
2021-08-20 10:53 ` [RFC PATCH v3 13/15] perf top: " Riccardo Mancini
2021-08-20 10:54 ` [RFC PATCH v3 14/15] perf test/synthesis: " Riccardo Mancini
2021-08-20 10:54 ` [RFC PATCH v3 15/15] perf synthetic-events: use workqueue parallel_for Riccardo Mancini
2021-08-29 21:59 ` [RFC PATCH v3 00/15] perf: add workqueue library and use it in synthetic-events Jiri Olsa
2021-08-31 15:46 ` Jiri Olsa
2021-08-31 16:57 ` Riccardo Mancini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSyHR7aP0OieedgE@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexey.v.bayduraev@linux.intel.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rickyman7@gmail.com \
--subject='Re: [RFC PATCH v3 07/15] perf workqueue: implement worker thread and management' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).