From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Ilya Dryomov <idryomov@gmail.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Rajat Jain <rajatja@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/9] ABI: sysfs-bus-usb: better document variable argument
Date: Mon, 13 Sep 2021 14:55:13 +0300 [thread overview]
Message-ID: <YT88IYrNS4a48aPK@kuha.fi.intel.com> (raw)
In-Reply-To: <8b01bf910a236796e5571fd089619d5f51a874f6.1631112725.git.mchehab+huawei@kernel.org>
On Wed, Sep 08, 2021 at 04:58:51PM +0200, Mauro Carvalho Chehab wrote:
> On almost all ABI documents, variable arguments are declared
> as <foo_bar>. Change it here too, in order to allow replacing
> such wildcards by regexes on a scriptable way.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> Documentation/ABI/testing/sysfs-bus-usb | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-usb b/Documentation/ABI/testing/sysfs-bus-usb
> index 73eb23bc1f34..42103f0f54d6 100644
> --- a/Documentation/ABI/testing/sysfs-bus-usb
> +++ b/Documentation/ABI/testing/sysfs-bus-usb
> @@ -166,14 +166,14 @@ Description:
> The file will be present for all speeds of USB devices, and will
> always read "no" for USB 1.1 and USB 2.0 devices.
>
> -What: /sys/bus/usb/devices/.../(hub interface)/portX
> +What: /sys/bus/usb/devices/.../<hub_interface>/port<X>
> Date: August 2012
> Contact: Lan Tianyu <tianyu.lan@intel.com>
> Description:
> - The /sys/bus/usb/devices/.../(hub interface)/portX
> + The /sys/bus/usb/devices/.../<hub_interface>/port<X>
> is usb port device's sysfs directory.
>
> -What: /sys/bus/usb/devices/.../(hub interface)/portX/connect_type
> +What: /sys/bus/usb/devices/.../<hub_interface>/port<X>/connect_type
> Date: January 2013
> Contact: Lan Tianyu <tianyu.lan@intel.com>
> Description:
> @@ -182,7 +182,7 @@ Description:
> The file will read "hotplug", "hardwired" and "not used" if the
> information is available, and "unknown" otherwise.
>
> -What: /sys/bus/usb/devices/.../(hub interface)/portX/location
> +What: /sys/bus/usb/devices/.../<hub_interface>/port<X>/location
> Date: October 2018
> Contact: Bjørn Mork <bjorn@mork.no>
> Description:
> @@ -192,7 +192,7 @@ Description:
> raw location value as a hex integer.
>
>
> -What: /sys/bus/usb/devices/.../(hub interface)/portX/quirks
> +What: /sys/bus/usb/devices/.../<hub_interface>/port<X>/quirks
> Date: May 2018
> Contact: Nicolas Boichat <drinkcat@chromium.org>
> Description:
> @@ -216,7 +216,7 @@ Description:
> used to help make enumeration work better on some high speed
> devices.
>
> -What: /sys/bus/usb/devices/.../(hub interface)/portX/over_current_count
> +What: /sys/bus/usb/devices/.../<hub_interface>/port<X>/over_current_count
> Date: February 2018
> Contact: Richard Leitner <richard.leitner@skidata.com>
> Description:
> @@ -230,10 +230,10 @@ Description:
> Any time this value changes the corresponding hub device will send a
> udev event with the following attributes::
>
> - OVER_CURRENT_PORT=/sys/bus/usb/devices/.../(hub interface)/portX
> + OVER_CURRENT_PORT=/sys/bus/usb/devices/.../<hub_interface>/port<X>
> OVER_CURRENT_COUNT=[current value of this sysfs attribute]
>
> -What: /sys/bus/usb/devices/.../(hub interface)/portX/usb3_lpm_permit
> +What: /sys/bus/usb/devices/.../<hub_interface>/port<X>/usb3_lpm_permit
> Date: November 2015
> Contact: Lu Baolu <baolu.lu@linux.intel.com>
> Description:
> --
> 2.31.1
--
heikki
next prev parent reply other threads:[~2021-09-13 11:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 14:58 [PATCH 0/9] get_abi.pl: Check for missing symbols at the ABI specs Mauro Carvalho Chehab
2021-09-08 14:58 ` [PATCH 1/9] scripts: " Mauro Carvalho Chehab
2021-09-08 14:58 ` [PATCH 2/9] scripts: get_abi.pl: detect softlinks Mauro Carvalho Chehab
2021-09-08 14:58 ` [PATCH 3/9] scripts: get_abi.pl: add an option to filter undefined results Mauro Carvalho Chehab
2021-09-08 14:58 ` [PATCH 4/9] ABI: sysfs-bus-usb: better document variable argument Mauro Carvalho Chehab
2021-09-13 11:55 ` Heikki Krogerus [this message]
2021-09-08 14:58 ` [PATCH 5/9] ABI: sysfs-module: better document module name parameter Mauro Carvalho Chehab
2021-09-08 14:58 ` [PATCH 6/9] ABI: sysfs-tty: " Mauro Carvalho Chehab
2021-09-08 14:58 ` [PATCH 7/9] ABI: sysfs-kernel-slab: use a wildcard for the cache name Mauro Carvalho Chehab
2021-09-08 14:58 ` [PATCH 8/9] ABI: security: fix location for evm and ima_policy Mauro Carvalho Chehab
2021-09-09 13:48 ` Mimi Zohar
2021-09-09 14:11 ` Mauro Carvalho Chehab
2021-09-08 14:58 ` [PATCH 9/9] ABI: sysfs-module: document initstate Mauro Carvalho Chehab
2021-09-09 13:51 ` [PATCH 0/9] get_abi.pl: Check for missing symbols at the ABI specs Greg KH
2021-09-14 14:24 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YT88IYrNS4a48aPK@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=idryomov@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=rajatja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).