From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25550C433F5 for ; Mon, 13 Sep 2021 16:27:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01F3960E76 for ; Mon, 13 Sep 2021 16:27:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237580AbhIMQ2x (ORCPT ); Mon, 13 Sep 2021 12:28:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:58544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229542AbhIMQ2v (ORCPT ); Mon, 13 Sep 2021 12:28:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A2D3760E76; Mon, 13 Sep 2021 16:27:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631550455; bh=+JU75Xr+8q9kiFLxr1qYENZSbwe5QYQ0hiW2ZF5UCD0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nYFQxeHb0GejwY1c9Wp9liAY4sMkenPKpjRCTclr2YunjCOr2wzwBBi9vD2HLuJqZ 3IggVeQkyIqLwrVt3TtoTcy1sxq3XNWr1A7EoQ19iUO4AiDMtfw7dRIDzG5S9R/ErQ Virp4+/ZMn77Wme4xWVuK6Tu0KOI5CrCApWRGLtE4bUotf+nENo1Dp2HzucqOyfds4 Cba13pYZKZZRD1iF0CGMasAJpGr9AEYYFMv2aJok+Sxg6guc6WB7HbFHtkdAOLL1ab lD5nLJ2m1ZC9wCVnN2Hsq3gLWEbNML9M0RDKvaoivMQMQFL5Tc/sYjsUHN4DOdrtYN 41BPrC2M6gogQ== Date: Mon, 13 Sep 2021 12:27:34 -0400 From: Sasha Levin To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Phillip Potter , kernel test robot , linux-staging@lists.linux.dev Subject: Re: [PATCH AUTOSEL 5.14 044/252] staging: rtl8188eu: remove rtw_wx_set_rate handler function Message-ID: References: <20210909114106.141462-1-sashal@kernel.org> <20210909114106.141462-44-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 09, 2021 at 01:48:49PM +0200, Greg Kroah-Hartman wrote: >On Thu, Sep 09, 2021 at 07:37:38AM -0400, Sasha Levin wrote: >> From: Phillip Potter >> >> [ Upstream commit ac5951a6e3d50cfa861ea83baa2ec15d994389cb ] >> >> Remove rtw_wx_set_rate handler function, which currently handles the >> SIOCSIWRATE wext ioctl. This function (although containing a lot of >> code) set nothing outside its own local variables, and did nothing other >> than call a now removed debugging statement repeatedly. Removing it and >> leaving its associated entry in rtw_handlers as NULL is therefore the >> better option. Removing this function also fixes a kernel test robot >> warning. >> >> Reported-by: kernel test robot >> Signed-off-by: Phillip Potter >> Link: https://lore.kernel.org/r/20210625191658.1299-1-phil@philpotter.co.uk >> Signed-off-by: Greg Kroah-Hartman >> Signed-off-by: Sasha Levin >> --- >> .../staging/rtl8188eu/os_dep/ioctl_linux.c | 75 ------------------- >> 1 file changed, 75 deletions(-) > >This whole driver is now gone in 5.15-rc1, so no need for doing anything >like this for older kernels. Please drop this patch from all branches. Dropped, thanks! -- Thanks, Sasha