From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47313C433FE for ; Mon, 13 Sep 2021 13:11:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 277266103B for ; Mon, 13 Sep 2021 13:11:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235976AbhIMNMW (ORCPT ); Mon, 13 Sep 2021 09:12:22 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:38106 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230042AbhIMNMT (ORCPT ); Mon, 13 Sep 2021 09:12:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=lhuklNqPbPBlUpzBlVfCCXYDNgKobxlQ6GFS6KR2OQ8=; b=VFE3T67fTCAfX+NiJZ6mngYyhG dgz/2pCeI3+dhERc0MFab+ofX3E9hBzzSbq7oI5hciXQ5+0Qih5eN/Q+TRDAzaP7FMGgtFLWStLQ8 pVrXAPEfwoyDDps6r/XhkAHRDr9f3gIIPe0HOhKOJqVyuEDPFGPIrNwMuXK3MD6o3Iro=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mPljD-006Ozw-Is; Mon, 13 Sep 2021 15:10:31 +0200 Date: Mon, 13 Sep 2021 15:10:31 +0200 From: Andrew Lunn To: Vladimir Oltean Cc: netdev@vger.kernel.org, Florian Fainelli , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Linus Walleij , George McCollister , Heiner Kallweit , Russell King , Oleksij Rempel , Michael Grzeschik , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Lino Sanfilippo Subject: Re: [RFC PATCH net 1/5] net: mdio: introduce a shutdown method to mdio device drivers Message-ID: References: <20210912120932.993440-1-vladimir.oltean@nxp.com> <20210912120932.993440-2-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210912120932.993440-2-vladimir.oltean@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 12, 2021 at 03:09:28PM +0300, Vladimir Oltean wrote: > MDIO-attached devices might have interrupts and other things that might > need quiesced when we kexec into a new kernel. Things are even more > creepy when those interrupt lines are shared, and in that case it is > absolutely mandatory to disable all interrupt sources. > > Moreover, MDIO devices might be DSA switches, and DSA needs its own > shutdown method to unlink from the DSA master, which is a new > requirement that appeared after commit 2f1e8ea726e9 ("net: dsa: link > interfaces with the DSA master to get rid of lockdep warnings"). > > So introduce a ->shutdown method in the MDIO device driver structure. > > Signed-off-by: Vladimir Oltean Reviewed-by: Andrew Lunn Andrew