From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2819DC43214 for ; Thu, 2 Sep 2021 05:58:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EED4B600CC for ; Thu, 2 Sep 2021 05:58:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241589AbhIBF7m (ORCPT ); Thu, 2 Sep 2021 01:59:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:53244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238732AbhIBF7k (ORCPT ); Thu, 2 Sep 2021 01:59:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6434760FC4; Thu, 2 Sep 2021 05:58:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630562323; bh=BwqwkSdoVWCyqzWTEEXTceIXMVKRB8SwogsNaQ7lvZI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C7LSfgtMMuexPix16DaTOH3ZmOTPFUlZ+0QlunclyfNWrFDaXWWHvVjHPECgfEZNb A8ffnAGdS3xUa7OtW6S3+ctupWMoTHuRTgRJOhCHlMCqlz25kbNNQzi5CBFAuINy64 fiNXWS1ZVAoh+5Zr6BccQx/iRX55Ibv2TcML/o+0= Date: Thu, 2 Sep 2021 07:58:37 +0200 From: Greg KH To: DENG Qingfang Cc: Sasha Levin , stable@vger.kernel.org, Sean Wang , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Matthias Brugger , "open list:MEDIATEK SWITCH DRIVER" , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Subject: Re: [PATCH 4.19.y] net: dsa: mt7530: disable learning on standalone ports Message-ID: References: <20210824055509.1316124-1-dqfext@gmail.com> <20210902053619.1824464-1-dqfext@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210902053619.1824464-1-dqfext@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 02, 2021 at 01:36:19PM +0800, DENG Qingfang wrote: > On Fri, Aug 27, 2021 at 12:19:23PM +0200, Greg KH wrote: > > On Tue, Aug 24, 2021 at 11:57:53PM +0800, DENG Qingfang wrote: > > > Standalone ports should have address learning disabled, according to > > > the documentation: > > > https://www.kernel.org/doc/html/v5.14-rc7/networking/dsa/dsa.html#bridge-layer > > > dsa_switch_ops on 5.10 or earlier does not have .port_bridge_flags > > > function so it has to be done differently. > > > > > > I've identified an issue related to this. > > > > What issue is that? Where was it reported? > > See Florian's message here > https://lore.kernel.org/stable/20210317003549.3964522-2-f.fainelli@gmail.com/ THat is just the patch changelog text, or is it unique to this stable-only patch? It is not obvious at all. > > > > 2. A partial backport of this patch? > > > > > > The other part does not actually fix anything. > > > > Then why is it not ok to just take the whole thing? > > > > When backporting not-identical-patches, something almost always goes > > wrong, so we prefer to take the original commit when ever possible. > > Okay. MDB and tag ops can be backported as is, and broadcast/multicast > flooding can be implemented in .port_egress_floods. So what are we supposed to do here? totally confused, greg k-h