linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH resend] Input: adc-keys - drop bogus __refdata annotation
@ 2021-07-14  9:38 Geert Uytterhoeven
  2021-07-16 16:51 ` Alexandre Belloni
  2021-09-04  6:28 ` Dmitry Torokhov
  0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-07-14  9:38 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: Alexandre Belloni, linux-input, linux-kernel, Geert Uytterhoeven

As the ADC ladder input driver does not have any code or data located in
initmem, there is no need to annotate the adc_keys_driver structure with
__refdata.  Drop the annotation, to avoid suppressing future section
warnings.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/input/keyboard/adc-keys.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/adc-keys.c b/drivers/input/keyboard/adc-keys.c
index 6d5be48d1b3d7988..bf72ab8df817756f 100644
--- a/drivers/input/keyboard/adc-keys.c
+++ b/drivers/input/keyboard/adc-keys.c
@@ -193,7 +193,7 @@ static const struct of_device_id adc_keys_of_match[] = {
 MODULE_DEVICE_TABLE(of, adc_keys_of_match);
 #endif
 
-static struct platform_driver __refdata adc_keys_driver = {
+static struct platform_driver adc_keys_driver = {
 	.driver = {
 		.name = "adc_keys",
 		.of_match_table = of_match_ptr(adc_keys_of_match),
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH resend] Input: adc-keys - drop bogus __refdata annotation
  2021-07-14  9:38 [PATCH resend] Input: adc-keys - drop bogus __refdata annotation Geert Uytterhoeven
@ 2021-07-16 16:51 ` Alexandre Belloni
  2021-09-04  6:28 ` Dmitry Torokhov
  1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2021-07-16 16:51 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Dmitry Torokhov, linux-input, linux-kernel

On 14/07/2021 11:38:33+0200, Geert Uytterhoeven wrote:
> As the ADC ladder input driver does not have any code or data located in
> initmem, there is no need to annotate the adc_keys_driver structure with
> __refdata.  Drop the annotation, to avoid suppressing future section
> warnings.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

I must admit I can't remember why I used that annotation...

> ---
>  drivers/input/keyboard/adc-keys.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/keyboard/adc-keys.c b/drivers/input/keyboard/adc-keys.c
> index 6d5be48d1b3d7988..bf72ab8df817756f 100644
> --- a/drivers/input/keyboard/adc-keys.c
> +++ b/drivers/input/keyboard/adc-keys.c
> @@ -193,7 +193,7 @@ static const struct of_device_id adc_keys_of_match[] = {
>  MODULE_DEVICE_TABLE(of, adc_keys_of_match);
>  #endif
>  
> -static struct platform_driver __refdata adc_keys_driver = {
> +static struct platform_driver adc_keys_driver = {
>  	.driver = {
>  		.name = "adc_keys",
>  		.of_match_table = of_match_ptr(adc_keys_of_match),
> -- 
> 2.25.1
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH resend] Input: adc-keys - drop bogus __refdata annotation
  2021-07-14  9:38 [PATCH resend] Input: adc-keys - drop bogus __refdata annotation Geert Uytterhoeven
  2021-07-16 16:51 ` Alexandre Belloni
@ 2021-09-04  6:28 ` Dmitry Torokhov
  1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2021-09-04  6:28 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Alexandre Belloni, linux-input, linux-kernel

On Wed, Jul 14, 2021 at 11:38:33AM +0200, Geert Uytterhoeven wrote:
> As the ADC ladder input driver does not have any code or data located in
> initmem, there is no need to annotate the adc_keys_driver structure with
> __refdata.  Drop the annotation, to avoid suppressing future section
> warnings.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Applied, thank you.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-04  6:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-14  9:38 [PATCH resend] Input: adc-keys - drop bogus __refdata annotation Geert Uytterhoeven
2021-07-16 16:51 ` Alexandre Belloni
2021-09-04  6:28 ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).