From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14CC3C433F5 for ; Tue, 7 Sep 2021 07:24:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA9D46109D for ; Tue, 7 Sep 2021 07:24:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233022AbhIGHZF (ORCPT ); Tue, 7 Sep 2021 03:25:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:38614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231324AbhIGHZE (ORCPT ); Tue, 7 Sep 2021 03:25:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id ADA4F6109D; Tue, 7 Sep 2021 07:23:56 +0000 (UTC) Date: Tue, 7 Sep 2021 08:23:54 +0100 From: Catalin Marinas To: Naohiro Aota Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org Subject: Re: [PATCH] mm/kmemleak: allow __GFP_NOLOCKDEP passed to kmemleak's gfp Message-ID: References: <20210907055659.3182992-1-naohiro.aota@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210907055659.3182992-1-naohiro.aota@wdc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 07, 2021 at 02:56:59PM +0900, Naohiro Aota wrote: > In a memory pressure situation, I'm seeing the lockdep WARNING below. > Actually, this is similar to a known false positive which is already > addressed by commit 6dcde60efd94 ("xfs: more lockdep whackamole with > kmem_alloc*"). > > This warning still persists because it's not from kmalloc() itself but > from an allocation for kmemleak object. While kmalloc() itself suppress > the warning with __GFP_NOLOCKDEP, gfp_kmemleak_mask() is dropping the > flag for the kmemleak's allocation. > > Allow __GFP_NOLOCKDEP to be passed to kmemleak's allocation, so that the > warning for it is also suppressed. > > ====================================================== > WARNING: possible circular locking dependency detected > 5.14.0-rc7-BTRFS-ZNS+ #37 Not tainted Acked-by: Catalin Marinas