From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 685A7C433EF for ; Tue, 7 Sep 2021 17:52:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43AFA61104 for ; Tue, 7 Sep 2021 17:52:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242931AbhIGRxw (ORCPT ); Tue, 7 Sep 2021 13:53:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:45142 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229601AbhIGRxv (ORCPT ); Tue, 7 Sep 2021 13:53:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6220461100; Tue, 7 Sep 2021 17:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631037165; bh=HoTCPvWh1JcRHv9ksbm1tgwNVMMgK0R96ieyDjdEISA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xn5TZIu9AdapdOP3wXNXSA2n2n1R/RsXvvB28P3Y9xH9iS7uUv//TqpHKuVjlGRAP HK4VykpjvBl900slDjflxDE98DCuy5mCuIn/9BExFMNKkMCRCruP5JcPBuiRPAgaOa 9O9UgyCWVhpxmryZaJmUnZ0zkktNROc0xbjehK10= Date: Tue, 7 Sep 2021 19:52:39 +0200 From: Greg KH To: Steven Rostedt Cc: Kalesh Singh , Suren Baghdasaryan , Hridya Valsaraju , John Reitan , =?iso-8859-1?Q?=D8rjan?= Eide , Mark Underwood , Gary Sweet , Stephen Mansfield , "Cc: Android Kernel" , Ingo Molnar , LKML Subject: Re: [RESEND v2] tracing/gpu: Add imported size to gpu_mem_imported tracepoint Message-ID: References: <20210831170233.1409537-1-kaleshsingh@google.com> <20210903163047.20e4f286@gandalf.local.home> <20210907134923.2dd41a8a@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210907134923.2dd41a8a@gandalf.local.home> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 07, 2021 at 01:49:23PM -0400, Steven Rostedt wrote: > On Fri, 3 Sep 2021 15:36:03 -0700 > Kalesh Singh wrote: > > > On Fri, Sep 3, 2021 at 1:30 PM Steven Rostedt wrote: > > > > > > On Tue, 31 Aug 2021 17:02:29 +0000 > > > Kalesh Singh wrote: > > > > > > > The existing gpu_mem_total tracepoint provides GPU drivers a uniform way > > > > to report the per-process and system-wide GPU memory usage. This > > > > tracepoint reports a single total of the GPU private allocations and the > > > > imported memory. [1] > > > > > > > > To allow distinguishing GPU private vs imported memory, add an > > > > imported_size field to the gpu_mem_total tracepoint. GPU drivers can use > > > > this new field to report the per-process and global GPU-imported memory > > > > in a uniform way. > > > > > > > > User space tools can detect and handle the old vs new gpu_mem_total > > > > format via the gpu_mem/gpu_mem_total/format file. > > > > > > > > [1] https://lore.kernel.org/r/20200302234840.57188-1-zzyiwei@google.com/ > > > > > > > > Signed-off-by: Kalesh Singh > > > > --- > > > > include/trace/events/gpu_mem.h | 17 +++++++++++------ > > > > 1 file changed, 11 insertions(+), 6 deletions(-) > > > > > > > > > > This is that trace event that doesn't have any in tree callers, right? I > > > thought there was going to be some soon. > > > > The trace event is currently used by the Android GPU drivers, and > > there is some work ongoing to add this in drm core upstream but it's > > not yet ready. > > > > > > > > For the updates to the tracing side (besides not having any users), it > > > looks trivial to me. > > > > > > Acked-by: Steven Rostedt (VMware) > > > > > > But this needs to be pulled in by one of the GPU maintainers. > > > > Thanks for the review Steve. I'll resend adding the GPU maintainers. > > OK, so it was Greg that gave me the Ack to accept it. Me? Hah, I'm not a gpu developer, they are the ones that need to ack this thing... greg k-h