From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D98BC4332F for ; Tue, 7 Sep 2021 18:16:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43C16610F8 for ; Tue, 7 Sep 2021 18:16:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345791AbhIGSSA (ORCPT ); Tue, 7 Sep 2021 14:18:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345736AbhIGSR7 (ORCPT ); Tue, 7 Sep 2021 14:17:59 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61B8BC06175F for ; Tue, 7 Sep 2021 11:16:52 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id i24so8813758pfo.12 for ; Tue, 07 Sep 2021 11:16:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MTKC20tO9zMCWTI8piOtIK2h9ol7uIIjMhJrYZXtkYg=; b=JP54FaieVXwvNpDq0XuDG07BQCdr2Dtael/Sn0U3W4F72gblOSgWKOsVQPfglUQAaR StOI2FGY99ADuiwTdcirDT+f0z6RhL7DTRVC6isDQEcfoj3yj9RU/kovpZIum8a+La0t Pz7XbBeLrdLb73e0g/FBjw0cAHp/L5prC+VWE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MTKC20tO9zMCWTI8piOtIK2h9ol7uIIjMhJrYZXtkYg=; b=aoiFftB8pGx+g0qcCjFDabO68D1tJe4FLfD1bi3lMDOqYQv2g469IpBATvwrSbOzYU Z6okPQbpxy8Myv3dt1fX3cXkiTHSPbmRJ+PAz0y7HSn8uEAj19lznT281TNRKXLwdam+ C1/HhnChuZiHMHaz1fy0TpCIzIixA+7jgyywzfgNbxrM63n5f03g2drAWGuwvPtEq0ZY pW+y5SmMT+GxoN0w7Sg1UA2C3z51w/iMAtW9lVY1ZedsStl5HBJz4EAiP7tjv9aovImc 3IIaD+DogGLrv3KaP4mEz5gQDOCP95OX4a6XUNMCU77chIBxGN/WfjBortJQ3wpK0nsu ezGw== X-Gm-Message-State: AOAM532LpWE2Ti0h22sljHrP+0Mg9kkSCQ+Fds4Sj6vjTg7SSzql+his HvWLMpikWOJY6DHP6ap/i7Bjfg== X-Google-Smtp-Source: ABdhPJx9jtF/JxyCIZPs2rLwflSaCsmFbpbllqX2GRRW80zYBwd0FSUQ8BPYOPQvDaCV2DUIfScgUA== X-Received: by 2002:a65:6a4b:: with SMTP id o11mr17543541pgu.278.1631038611904; Tue, 07 Sep 2021 11:16:51 -0700 (PDT) Received: from localhost ([2620:15c:202:201:c6b2:7ae:474d:36f6]) by smtp.gmail.com with UTF8SMTPSA id h4sm3704143pjc.28.2021.09.07.11.16.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Sep 2021 11:16:51 -0700 (PDT) Date: Tue, 7 Sep 2021 11:16:49 -0700 From: Matthias Kaehlcke To: satya priya Cc: Pavel Machek , Rob Herring , Andy Gross , Bjorn Andersson , swboyd@chromium.org, kgunda@codeaurora.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 3/3] arm64: dts: qcom: pm8350c: Add pwm support Message-ID: References: <1630924867-4663-1-git-send-email-skakit@codeaurora.org> <1630924867-4663-4-git-send-email-skakit@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1630924867-4663-4-git-send-email-skakit@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 06, 2021 at 04:11:07PM +0530, satya priya wrote: > Add pwm support for PM8350C pmic. > > Signed-off-by: satya priya > --- > arch/arm64/boot/dts/qcom/pm8350c.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi > index e1b75ae..ecdae55 100644 > --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi > +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi > @@ -29,6 +29,12 @@ > interrupt-controller; > #interrupt-cells = <2>; > }; > + > + pm8350c_pwm4: pwm { What does the '4' represent, an internal channel number? It should probably be omitted if the PM8350 only has a single output PWM port. > + compatible = "qcom,pm8350c-pwm"; > + #pwm-cells = <2>; > + status = "okay"; I don't think it should be enabled by default, there may be boards with the PM8350C that don't use the PWM.