From: Sean Christopherson <seanjc@google.com>
To: Brijesh Singh <brijesh.singh@amd.com>
Cc: Mingwei Zhang <mizhang@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
John Allen <john.allen@amd.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, Alper Gun <alpergun@google.com>,
Borislav Petkov <bp@alien8.de>,
David Rienjes <rientjes@google.com>,
Marc Orr <marcorr@google.com>, Peter Gonda <pgonda@google.com>,
Vipin Sharma <vipinsh@google.com>
Subject: Re: [PATCH v2 3/4] KVM: SVM: move sev_bind_asid to psp
Date: Tue, 7 Sep 2021 23:37:29 +0000 [thread overview]
Message-ID: <YTf3udAv1TZzW+xA@google.com> (raw)
In-Reply-To: <fcb83a85-8150-9617-01e6-c6bcc249c485@amd.com>
On Tue, Sep 07, 2021, Brijesh Singh wrote:
>
> On 9/3/21 2:38 PM, Sean Christopherson wrote:
> > My personal preference is obviously to work towards an abstracted API. And if
> > we decide to go that route, I think we should be much more aggressive with respect
> > to what is abstracted. Many of the functions will be rather gross due to the
> > sheer number of params, but I think the end result will be a net positive in terms
> > of readability and separation of concerns.
> >
> > E.g. get KVM looking like this
> >
> > static int sev_receive_start(struct kvm *kvm, struct kvm_sev_cmd *argp)
> > {
> > struct kvm_sev_info *sev = &to_kvm_svm(kvm)->sev_info;
> > struct kvm_sev_receive_start params;
> > int ret;
> >
> > if (!sev_guest(kvm))
> > return -ENOTTY;
> >
> > /* Get parameter from the userspace */
> > if (copy_from_user(¶ms, (void __user *)(uintptr_t)argp->data,
> > sizeof(struct kvm_sev_receive_start)))
> > return -EFAULT;
> >
> > ret = sev_guest_receive_start(argp->sev_fd, &arpg->error, sev->asid,
> > ¶ms.handle, params.policy,
> > params.pdh_uaddr, params.pdh_len,
> > params.session_uaddr, params.session_len);
> > if (ret)
> > return ret;
> >
> > /* Copy params back to user even on failure, e.g. for error info. */
> > if (copy_to_user((void __user *)(uintptr_t)argp->data,
> > ¶ms, sizeof(struct kvm_sev_receive_start)))
> > return -EFAULT;
> >
> > sev->handle = params.handle;
> > sev->fd = argp->sev_fd;
> > return 0;
> > }
> >
>
> I have no strong preference for either of the abstraction approaches. The
> sheer number of argument can also make some folks wonder whether such
> abstraction makes it easy to read. e.g send-start may need up to 11.
Yeah, that's brutal, but IMO having a few ugly functions is an acceptable cost if
it means the rest of the API is cleaner. E.g. KVM is not the right place to
implement sev_deactivate_lock, as any coincident DEACTIVATE will be problematic.
The current code "works" because KVM is the only in-tree user, but even that's a
bit of a grey area because sev_guest_deactivate() is exported.
If large param lists are problematic, one idea would be to reuse the sev_data_*
structs for the API. I still don't like the idea of exposing those structs
outside of the PSP driver, and the potential user vs. kernel pointer confusion
is more than a bit ugly. On the other hand it's not exactly secret info,
e.g. KVM's UAPI structs are already excrutiatingly close to sev_data_* structs.
For future ioctls(), KVM could even define UAPI structs that are bit-for-bit
compatible with the hardware structs. That would allow KVM to copy userspace's
data directly into a "struct sev_data_*" and simply require the handle and any
other KVM-defined params to be zero. KVM could then hand the whole struct over
to the PSP driver for processing.
We can even do a direct copy to sev_data* with KVM's current UAPI by swapping
fields as necessary, e.g. swap policy<->handle before and after send-start, but
that's all kinds of gross and probably not a net positive.
next prev parent reply other threads:[~2021-09-07 23:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 5:39 [PATCH v2 0/4] clean up interface between KVM and psp Mingwei Zhang
2021-08-18 5:39 ` [PATCH v2 1/4] KVM: SVM: fix missing sev_decommission in sev_receive_start Mingwei Zhang
2021-08-21 2:11 ` Marc Orr
2021-08-21 2:30 ` Marc Orr
2021-08-18 5:39 ` [PATCH v2 2/4] KVM: SVM: move sev_decommission to psp driver Mingwei Zhang
2021-08-18 5:39 ` [PATCH v2 3/4] KVM: SVM: move sev_bind_asid to psp Mingwei Zhang
2021-09-03 19:38 ` Sean Christopherson
2021-09-07 16:30 ` Brijesh Singh
2021-09-07 23:37 ` Sean Christopherson [this message]
2021-09-09 16:07 ` Brijesh Singh
2021-09-09 18:13 ` Sean Christopherson
2021-09-09 21:18 ` Mingwei Zhang
2021-09-09 22:25 ` Brijesh Singh
2021-09-10 1:18 ` Mingwei Zhang
2021-09-10 1:23 ` Marc Orr
2021-08-18 5:39 ` [PATCH v2 4/4] KVM: SVM: move sev_unbind_asid and DF_FLUSH logic into psp Mingwei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTf3udAv1TZzW+xA@google.com \
--to=seanjc@google.com \
--cc=alpergun@google.com \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=jmattson@google.com \
--cc=john.allen@amd.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcorr@google.com \
--cc=mizhang@google.com \
--cc=pbonzini@redhat.com \
--cc=pgonda@google.com \
--cc=rientjes@google.com \
--cc=thomas.lendacky@amd.com \
--cc=vipinsh@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).