From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EA26C433FE for ; Wed, 8 Sep 2021 04:52:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 292AE60EB7 for ; Wed, 8 Sep 2021 04:52:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231738AbhIHExi (ORCPT ); Wed, 8 Sep 2021 00:53:38 -0400 Received: from zeniv-ca.linux.org.uk ([142.44.231.140]:40224 "EHLO zeniv-ca.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbhIHExh (ORCPT ); Wed, 8 Sep 2021 00:53:37 -0400 Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNpVA-002DI1-Tc; Wed, 08 Sep 2021 04:48:00 +0000 Date: Wed, 8 Sep 2021 04:48:00 +0000 From: Al Viro To: Guenter Roeck Cc: Linus Torvalds , "David S. Miller" , Dmitry Torokhov , Christian Koenig , Huang Rui , Linux Kernel Mailing List , linux-sparc Subject: Re: [PATCH] Enable '-Werror' by default for all kernel builds Message-ID: References: <20210906142615.GA1917503@roeck-us.net> <20210906234921.GA1394069@roeck-us.net> <20210908042838.GA2585993@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210908042838.GA2585993@roeck-us.net> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 07, 2021 at 09:28:38PM -0700, Guenter Roeck wrote: > memcpy(eth_addr, sanitize_address((void *) 0xfffc1f2c), ETH_ALEN); > > but that just seems weird. Is there a better solution ? (char (*)[ETH_ALEN])? Said that, shouldn't that be doing something like ioremap(), rather than casting explicit constants?